Add flags and experiment config for selecting triggering heuristics

Add flags and experiment config for selecting triggering heuristics

BUG=454477, 471439
Committed: https://crrev.com/e928146e32e9570db279b4b34c99ed88b8a5efee
Cr-Commit-Position: refs/heads/master@{#323875}

[cjhopman, 2015-04-01 02:19:08]

cjhopman@chromium.org changed reviewers:
+ nyquist@chromium.org

[cjhopman, 2015-04-01 02:19:08]

nyquist: *

[nyquist, 2015-04-01 18:17:01]

https://codereview.chromium.org/1051673002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/experiments.cc (right):

https://codereview.chromium.org/1051673002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/experiments.cc:10: DistillerHeuristicsType
GetDistillerHeuristicsType() {
Should this check the flags as well? Or is that somehow some implicit field
trial magic?

[cjhopman, 2015-04-01 19:22:55]

https://codereview.chromium.org/1051673002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/experiments.cc (right):

https://codereview.chromium.org/1051673002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/experiments.cc:10: DistillerHeuristicsType
GetDistillerHeuristicsType() {
On 2015/04/01 18:17:01, nyquist wrote:
> Should this check the flags as well? Or is that somehow some implicit field
> trial magic?

That's implicit field trial magic. Adding the flags will put the user in one of
the Forced groups.

[nyquist, 2015-04-01 20:35:10]

lgtm

[cjhopman, 2015-04-01 21:06:20]

https://codereview.chromium.org/1051673002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/experiments.cc (right):

https://codereview.chromium.org/1051673002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/experiments.cc:10: DistillerHeuristicsType
GetDistillerHeuristicsType() {
On 2015/04/01 19:22:54, cjhopman wrote:
> On 2015/04/01 18:17:01, nyquist wrote:
> > Should this check the flags as well? Or is that somehow some implicit field
> > trial magic?
> 
> That's implicit field trial magic. Adding the flags will put the user in one
of
> the Forced groups.

I've added explicitly checking the flags though which will allow us to actually
use this before the experiment configs are rolled out.

[cjhopman, 2015-04-02 01:52:35]

Patchset #2 (id:20001) has been deleted

[cjhopman, 2015-04-03 23:09:12]

The CQ bit was checked by cjhopman@chromium.org

[cjhopman, 2015-04-03 23:09:13]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1051673002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-03 23:09:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1051673002/60001

[commit-bot: I haz the power, 2015-04-04 06:00:50]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-04-04 06:01:35]

Patchset 3 (id:??) landed as
https://crrev.com/e928146e32e9570db279b4b34c99ed88b8a5efee
Cr-Commit-Position: refs/heads/master@{#323875}