Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Side by Side Diff: site/dev/sheriffing/index.md

Issue 1051653006: Add sheriff documentation for rebaselining. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: No top level numbers Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Tree Sheriffs Documentation 1 Tree Sheriffs Documentation
2 =========================== 2 ===========================
3 3
4 ### Contents ### 4 ### Contents ###
5 5
6 * [What does a sheriff do?](#what_is_a_sheriff) 6 * [What does a sheriff do?](#what_is_a_sheriff)
7 + [Skia tree](#skia_tree) 7 + [Skia tree](#skia_tree)
8 + [DEPS rolls](#deps_rolls) 8 + [DEPS rolls](#deps_rolls)
9 + [Gold and Perf](#gold_and_perf) 9 + [Gold and Perf](#gold_and_perf)
10 + [Documentation](#sheriff_doc) 10 + [Documentation](#sheriff_doc)
11 * [View current and upcoming sheriffs](#view_current_upcoming_sheriffs) 11 * [View current and upcoming sheriffs](#view_current_upcoming_sheriffs)
12 * [How to swap sheriff shifts](#how_to_swap) 12 * [How to swap sheriff shifts](#how_to_swap)
13 * [Tips for sheriffs](#tips) 13 * [Tips for sheriffs](#tips)
14 + [When to file bugs](#when_to_file_bugs) 14 + [When to file bugs](#when_to_file_bugs)
15 + [How to close or re-open the tree](#how_close_tree) 15 + [How to close or re-open the tree](#how_close_tree)
16 + [Compile bot failures automatically close the tree](#tree_closers) 16 + [Compile bot failures automatically close the tree](#tree_closers)
17 + [How to revert a CL](#how_to_revert) 17 + [How to revert a CL](#how_to_revert)
18 + [What to do if DEPS roll fails to land](#deps_roll_failures) 18 + [What to do if DEPS roll fails to land](#deps_roll_failures)
19 + [How to rebaseline](#how_to_rebaseline)
19 20
20 21
21 <a name="what_is_a_sheriff"></a> 22 <a name="what_is_a_sheriff"></a>
22 What does a sheriff do? 23 What does a sheriff do?
23 ----------------------- 24 -----------------------
24 25
25 A sheriff keeps an eye on the tree, DEPS rolls, Gold tool and the Perf tool. 26 A sheriff keeps an eye on the tree, DEPS rolls, Gold tool and the Perf tool.
26 27
27 Below is a brief summary of what the sheriff does for each task: 28 Below is a brief summary of what the sheriff does for each task:
28 29
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 <a name="how_to_revert"></a> 106 <a name="how_to_revert"></a>
106 ### How to revert a CL 107 ### How to revert a CL
107 108
108 See the revert documentation [here](https://skia.org/dev/contrib/revert). 109 See the revert documentation [here](https://skia.org/dev/contrib/revert).
109 110
110 111
111 <a name="deps_roll_failures"></a> 112 <a name="deps_roll_failures"></a>
112 ### What to do if DEPS roll fails to land 113 ### What to do if DEPS roll fails to land
113 114
114 A common cause of DEPS roll failures are layout tests. Find the offending Skia C L by examining the commit hash range in the DEPS roll and revert (or talk to the commit author if they are available). If you do revert then keep an eye on the next DEPS roll to make sure it succeeds. 115 A common cause of DEPS roll failures are layout tests. Find the offending Skia C L by examining the commit hash range in the DEPS roll and revert (or talk to the commit author if they are available). If you do revert then keep an eye on the next DEPS roll to make sure it succeeds.
116
117 If a Skia CL changes layout tests, but the new images look good, the tests need to be rebaselined. See [Rebaseline Layout Tests](#how_to_rebaseline).
118
119 <a name="how_to_rebaseline"</a>
120 ### Rebaseline Layout Tests (i.e., add suppressions)
121
122 * First create a Chromium bug:
123 * goto [crbug.com](https://crbug.com)
124 * Make sure you’re logged in with your Chromium credentials
125 * Click “New Issue”
126 * Summary: “Skia image rebaseline”
127 * Description:
128 * DEPS roll #,
129 * Helpful message about what went wrong (e.g., “Changes to how lighting is s caled in Skia r#### changed the following images:”)
130 * Layout tests effected
131 * You should copy the list of affected from stdio of the failing bot
132 * Status: Assigned
133 * Owner: fmalita@
134 * cc: reed@, bsalomon@, robertphillips@ & developer responsible for changes
135 * Labels: OS-All & Cr-Blink-LayoutTests
136 * If it is filter related, cc senorblanco@
137
138 * Edit [skia/skia_test_expectations.txt](https://chromium.googlesource.com/chrom ium/src/+/master/skia/skia_test_expectations.txt)
139 * Add # comment about what has changed (I usually paraphrase the crbug text)
140 * Add line(s) like after the comment:
141 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ ImageOnlyFailure ]
142
143 * Commit the changes and fire off new try bots (you usually only need to fire of f the layout bots)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698