Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1051653004: Add NaCl SDK release note about LLVM 3.6 and debug metadata changes. (Closed)

Created:
5 years, 8 months ago by jvoung (off chromium)
Modified:
5 years, 8 months ago
Reviewers:
JF, binji, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NaCl SDK release note about LLVM 3.6 and debug metadata changes. BUG=none Committed: https://crrev.com/97dadb1ec0ee2ee903fcf82b0a7e38d2001a2ccd Cr-Commit-Position: refs/heads/master@{#323291}

Patch Set 1 #

Patch Set 2 : line wrap #

Total comments: 4

Patch Set 3 : reword version matching #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M native_client_sdk/doc_generated/devguide/devcycle/debugging.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/sdk/release-notes.html View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/debugging.rst View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/doc/sdk/release-notes.rst View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jvoung (off chromium)
5 years, 8 months ago (2015-04-01 15:52:49 UTC) #2
JF
lgtm
5 years, 8 months ago (2015-04-01 16:34:39 UTC) #3
binji
https://codereview.chromium.org/1051653004/diff/20001/native_client_sdk/src/doc/sdk/release-notes.rst File native_client_sdk/src/doc/sdk/release-notes.rst (right): https://codereview.chromium.org/1051653004/diff/20001/native_client_sdk/src/doc/sdk/release-notes.rst#newcode24 native_client_sdk/src/doc/sdk/release-notes.rst:24: remember that the SDK version must match the in-browser ...
5 years, 8 months ago (2015-04-01 16:59:01 UTC) #4
jvoung (off chromium)
https://codereview.chromium.org/1051653004/diff/20001/native_client_sdk/src/doc/sdk/release-notes.rst File native_client_sdk/src/doc/sdk/release-notes.rst (right): https://codereview.chromium.org/1051653004/diff/20001/native_client_sdk/src/doc/sdk/release-notes.rst#newcode24 native_client_sdk/src/doc/sdk/release-notes.rst:24: remember that the SDK version must match the in-browser ...
5 years, 8 months ago (2015-04-01 17:22:57 UTC) #5
binji
lgtm
5 years, 8 months ago (2015-04-01 17:51:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051653004/40001
5 years, 8 months ago (2015-04-01 18:13:43 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-01 18:55:03 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 18:56:09 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/97dadb1ec0ee2ee903fcf82b0a7e38d2001a2ccd
Cr-Commit-Position: refs/heads/master@{#323291}

Powered by Google App Engine
This is Rietveld 408576698