Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1051643003: Update {virtual,override} to follow C++11 style in tools. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in tools. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was ironically generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/8787d39596aa89b0e83dc89b361e1eb80253e246 Cr-Commit-Position: refs/heads/master@{#326452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M tools/clang/blink_gc_plugin/Edge.h View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
thakis -- please review
5 years, 8 months ago (2015-04-23 04:07:11 UTC) #2
Nico
lgtm
5 years, 8 months ago (2015-04-23 04:36:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051643003/1
5 years, 8 months ago (2015-04-23 04:38:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 04:42:27 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 04:44:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8787d39596aa89b0e83dc89b361e1eb80253e246
Cr-Commit-Position: refs/heads/master@{#326452}

Powered by Google App Engine
This is Rietveld 408576698