Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1051593003: Refactors code for WebGestureCurve to ui/events/gestures/blink (Closed)

Created:
5 years, 8 months ago by sky
Modified:
5 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, jdduke+watch_chromium.org, qsr+mojo_chromium.org, tdresser+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactors code for WebGestureCurve to ui/events/gestures/blink This way html_viewer can use it. R=sadrul@chromium.org, jochen@chromium.org Committed: https://crrev.com/d3145c8315ae29cefae2e030bbaacbdc68551fd9 Cr-Commit-Position: refs/heads/master@{#323597}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix gyp #

Patch Set 4 : include #

Patch Set 5 : fix namespace of test #

Patch Set 6 : fix gyp #

Patch Set 7 : fix gn #

Patch Set 8 : fix gn #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -310 lines) Patch
M content/child/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
D content/child/web_gesture_curve_impl.h View 1 chunk +0 lines, -66 lines 0 comments Download
D content/child/web_gesture_curve_impl.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D content/child/web_gesture_curve_impl_unittest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M content/content_child.gypi View 1 2 3 4 5 6 2 chunks +1 line, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/html_viewer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M ui/events/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 chunks +19 lines, -0 lines 1 comment Download
A + ui/events/gestures/blink/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
A ui/events/gestures/blink/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A + ui/events/gestures/blink/web_gesture_curve_impl.h View 4 chunks +8 lines, -13 lines 0 comments Download
A + ui/events/gestures/blink/web_gesture_curve_impl.cc View 5 chunks +8 lines, -8 lines 0 comments Download
A + ui/events/gestures/blink/web_gesture_curve_impl_unittest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sky
sadrul: ui jochen: the rest
5 years, 8 months ago (2015-04-01 16:23:26 UTC) #1
jochen (gone - plz use gerrit)
the rest lgtm
5 years, 8 months ago (2015-04-02 07:25:10 UTC) #2
sadrul
lgtm https://codereview.chromium.org/1051593003/diff/130001/ui/events/events.gyp File ui/events/events.gyp (right): https://codereview.chromium.org/1051593003/diff/130001/ui/events/events.gyp#newcode205 ui/events/events.gyp:205: 'type': 'static_library', Any reason this isn't component?
5 years, 8 months ago (2015-04-02 15:40:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051593003/130001
5 years, 8 months ago (2015-04-02 17:34:34 UTC) #7
commit-bot: I haz the power
Committed patchset #8 (id:130001)
5 years, 8 months ago (2015-04-03 05:06:02 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:30:45 UTC) #9
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/d3145c8315ae29cefae2e030bbaacbdc68551fd9
Cr-Commit-Position: refs/heads/master@{#323597}

Powered by Google App Engine
This is Rietveld 408576698