Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1051533002: test: Move util/test to its own top-level directory, test (Closed)

Created:
5 years, 8 months ago by Mark Mentovai
Modified:
5 years, 8 months ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

test: Move util/test to its own top-level directory, test. After 9e79ea1da719, it no longer makes sense for crashpad_util_test_lib to “hide” in util/util_test.gyp. All of util/test is moved to its own top-level directory, test, which all other test code is allowed to depend on. test, too, is allowed to depend on all other non-test code. In a future change, when crashpad_util_test_lib gains a dependency on crashpad_client, it won’t look so weird for something in util (even though it’s in util/test) to depend on something in client, because the thing that needs to depend on client will live in test, not util. BUG=crashpad:33 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/809ea8158dd3ffaff9f8efad461f3082687cc2ec

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -3230 lines) Patch
M build/run_tests.py View 1 chunk +1 line, -0 lines 0 comments Download
M client/client_test.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M client/crash_report_database_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M client/settings_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M client/simple_string_dictionary_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M client/simulate_crash_mac_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M crashpad.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M minidump/minidump_exception_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_file_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_module_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_test.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_thread_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/crashpad_info_client_options_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/mach_o_image_annotations_reader_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M snapshot/mac/mach_o_image_reader_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/process_reader_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M snapshot/mac/process_types_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/system_snapshot_mac_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/snapshot_test.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/errors.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/errors.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/gtest_death_check.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/mac/dyld.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/mac/mach_errors.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/mac/mach_errors.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mac/mach_multiprocess.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + test/mac/mach_multiprocess.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + test/mac/mach_multiprocess_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/multiprocess.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/multiprocess_exec.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + test/multiprocess_exec_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + test/multiprocess_exec_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/multiprocess_exec_test_child.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/multiprocess_exec_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/multiprocess_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + test/multiprocess_posix_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + test/paths.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/paths.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + test/paths_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/paths_test.cc View 2 chunks +4 lines, -5 lines 0 comments Download
A + test/paths_test_data_root.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/paths_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/scoped_temp_dir.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/scoped_temp_dir.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/scoped_temp_dir_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + test/scoped_temp_dir_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + test/scoped_temp_dir_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/test.gyp View 1 2 3 chunks +30 lines, -30 lines 0 comments Download
A + test/test_test.gyp View 1 2 2 chunks +17 lines, -17 lines 0 comments Download
A + test/thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/thread.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/thread_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/thread_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/file/file_io_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M util/mac/xattr_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/mach/child_port_handshake_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/composite_mach_message_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exc_client_variants_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/mach/exception_ports_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M util/mach/mach_extensions_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/mach_message_server_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/mach/mach_message_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/notify_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/scoped_task_suspend_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/mach/task_memory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/misc/initialization_state_dcheck_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/misc/scoped_forbid_return_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/net/http_body_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/net/http_multipart_builder_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/net/http_transport_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/posix/process_info_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D util/test/errors.h View 1 chunk +0 lines, -82 lines 0 comments Download
D util/test/errors.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D util/test/gtest_death_check.h View 1 chunk +0 lines, -55 lines 0 comments Download
D util/test/mac/dyld.h View 1 chunk +0 lines, -29 lines 0 comments Download
D util/test/mac/mach_errors.h View 1 chunk +0 lines, -70 lines 0 comments Download
D util/test/mac/mach_errors.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D util/test/mac/mach_multiprocess.h View 1 chunk +0 lines, -120 lines 0 comments Download
D util/test/mac/mach_multiprocess.cc View 1 chunk +0 lines, -280 lines 0 comments Download
D util/test/mac/mach_multiprocess_test.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D util/test/multiprocess.h View 1 chunk +0 lines, -206 lines 0 comments Download
D util/test/multiprocess_exec.h View 1 chunk +0 lines, -78 lines 0 comments Download
D util/test/multiprocess_exec_posix.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D util/test/multiprocess_exec_test.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D util/test/multiprocess_exec_test_child.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D util/test/multiprocess_exec_win.cc View 1 chunk +0 lines, -206 lines 0 comments Download
D util/test/multiprocess_posix.cc View 1 chunk +0 lines, -220 lines 0 comments Download
D util/test/multiprocess_posix_test.cc View 1 chunk +0 lines, -290 lines 0 comments Download
D util/test/paths.h View 1 chunk +0 lines, -49 lines 0 comments Download
D util/test/paths.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D util/test/paths_mac.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D util/test/paths_test.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D util/test/paths_test_data_root.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D util/test/paths_win.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D util/test/scoped_temp_dir.h View 1 chunk +0 lines, -64 lines 0 comments Download
D util/test/scoped_temp_dir.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D util/test/scoped_temp_dir_posix.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D util/test/scoped_temp_dir_test.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D util/test/scoped_temp_dir_win.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D util/test/thread.h View 1 chunk +0 lines, -70 lines 0 comments Download
D util/test/thread.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D util/test/thread_posix.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D util/test/thread_win.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M util/thread/thread_log_messages_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/util_test.gyp View 1 2 4 chunks +5 lines, -63 lines 1 comment Download
M util/win/process_info_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This is mostly a mechanical mv and sed, although I had to manually re-sort the ...
5 years, 8 months ago (2015-03-31 21:30:24 UTC) #2
scottmg
lgtm
5 years, 8 months ago (2015-03-31 21:43:39 UTC) #3
Mark Mentovai
5 years, 8 months ago (2015-03-31 21:44:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
809ea8158dd3ffaff9f8efad461f3082687cc2ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698