Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1051523003: [es6] Object.getPrototypeOf should work with values (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 8 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Object.getPrototypeOf should work with values This reverts commit 992751d0dc5be63845a371cb9fb2c1313efb3bdf. The final spec for Object.getPrototypeOf calls ToObject on the parameter, which means that it should only throw for null and undefined. For other non object values the prototype of the wrapper should be used. Difference from last time: Updated .status and will disable Blink side tests as needed. BUG=v8:3964 LOG=N R=adamk, rossberg@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/d4a314f9dcf7fee20ae9ad74e9573d651a0e43bb Cr-Commit-Position: refs/heads/master@{#27558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -52 lines) Patch
M src/v8natives.js View 1 chunk +2 lines, -5 lines 0 comments Download
M test/mjsunit/get-prototype-of.js View 1 chunk +66 lines, -32 lines 0 comments Download
M test/mjsunit/harmony/set-prototype-of.js View 1 chunk +2 lines, -8 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/test262/test262.status View 2 chunks +6 lines, -0 lines 0 comments Download
M test/webkit/prototypes.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/prototypes-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 8 months ago (2015-03-31 19:54:57 UTC) #1
adamk
lgtm
5 years, 8 months ago (2015-03-31 19:58:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051523003/1
5 years, 8 months ago (2015-03-31 23:17:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 00:22:45 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 00:22:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4a314f9dcf7fee20ae9ad74e9573d651a0e43bb
Cr-Commit-Position: refs/heads/master@{#27558}

Powered by Google App Engine
This is Rietveld 408576698