gpu/command_buffer/service/in_process_command_buffer.cc - Issue 1051503003: Add R_8 GPU memory buffers format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/in_process_command_buffer.cc

Issue 1051503003: Add R_8 GPU memory buffers format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reveman's nits. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/in_process_command_buffer.cc

diff --git a/gpu/command_buffer/service/in_process_command_buffer.cc b/gpu/command_buffer/service/in_process_command_buffer.cc

index 65986f82540b9945fb79f2d626b319bbe4b5dbfb..71a6532c0b89ef847abd1c3d6164b91115046730 100644

--- a/gpu/command_buffer/service/in_process_command_buffer.cc

+++ b/gpu/command_buffer/service/in_process_command_buffer.cc

@@ -713,6 +713,8 @@ int32 InProcessCommandBuffer::CreateImage(ClientBuffer buffer,

int32 new_id = next_image_id_.GetNext();

+ DCHECK(gpu::ImageFactory::IsGpuMemoryBufferFormatSupported(

+ gpu_memory_buffer->GetFormat(), capabilities_));

reveman 2015/04/08 02:57:28 thanks

DCHECK(gpu::ImageFactory::IsImageFormatCompatibleWithGpuMemoryBufferFormat(

internalformat, gpu_memory_buffer->GetFormat()));