gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt - Issue 1051503003: Add R_8 GPU memory buffers format.

Side by Side Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt

Issue 1051503003: Add R_8 GPU memory buffers format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reveman@'s comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc ('K') | « content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc ('k') | gpu/command_buffer/client/gles2_implementation.cc » ('j') | gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Name	1 Name

2	2

3 CHROMIUM_image	3 CHROMIUM_image

4	4

5 Name Strings	5 Name Strings

6	6

7 GL_CHROMIUM_image	7 GL_CHROMIUM_image

8	8

9 Version	9 Version

10	10

11 Last Modifed Date: Oct 7, 2014	11 Last Modifed Date: Oct 7, 2014

12	12

13 Dependencies	13 Dependencies

14	14

15 OpenGL ES 2.0 is required.	15 OpenGL ES 2.0 is required.

16	16
	reveman 2015/04/01 23:38:55 Please add this line here: "ARB_texture_rg affect Please add this line here: "ARB_texture_rg affects the definition of this extension." and this after the "New Procedures and Functions" section: " Dependencies on ARB_texture_rg If ARB_texture_rg is not supported: * delete any reference to the R8 format. " Daniele Castagna 2015/04/03 01:08:15 There is also EXT_texture_rg with its R8_EXT that Show quoted text On 2015/04/01 at 23:38:55, reveman wrote: > Please add this line here: > > "ARB_texture_rg affects the definition of this extension." > There is also EXT_texture_rg with its R8_EXT that has the same value as R8. Should we mention that? Show quoted text > and this after the "New Procedures and Functions" section: > > " > Dependencies on ARB_texture_rg > > If ARB_texture_rg is not supported: > * delete any reference to the R8 format. > " This is not completely true. R8 is available after OpengGL ES 3 even if there is no extension.
17 Overview	17 Overview

18	18

19 This extension defines a new resource type that is suitable for	19 This extension defines a new resource type that is suitable for

20 sharing 2D arrays of image data between client APIs.	20 sharing 2D arrays of image data between client APIs.

21	21

22 Issues	22 Issues

23	23

24 None	24 None

25	25

26 New Tokens	26 New Tokens

27	27

28 None	28 None

29	29

30 New Procedures and Functions	30 New Procedures and Functions

31	31

32 GLuint CreateImageCHROMIUM(ClientBuffer buffer,	32 GLuint CreateImageCHROMIUM(ClientBuffer buffer,

33 GLsizei width,	33 GLsizei width,

34 GLsizei height,	34 GLsizei height,

35 GLenum internalformat)	35 GLenum internalformat)

36	36

37 Create an image from <buffer> with width equal to <width> and	37 Create an image from <buffer> with width equal to <width> and

38 height equal to <height> and format equal to <internalformat>.	38 height equal to <height> and format equal to <internalformat>.

39	39

40 Returns a unique identifier for the image that could be used in	40 Returns a unique identifier for the image that could be used in

41 subsequent operations.	41 subsequent operations.

42	42

43 INVALID_VALUE is generated if <width> or <height> is nonpositive.	43 INVALID_VALUE is generated if <width> or <height> is nonpositive.

44	44

45 INVALID_ENUM is generated if <internalformat> is not one of	45 INVALID_ENUM is generated if <internalformat> is not one of

46 RGB or RGBA.	46 LUMINANCE, R8, RGB or RGBA.

47	47

48 void DestroyImageCHROMIUM(GLuint image_id)	48 void DestroyImageCHROMIUM(GLuint image_id)

49	49

50 Frees the image previously created by a call to CreateImageCHROMIUM.	50 Frees the image previously created by a call to CreateImageCHROMIUM.

51	51

52 INVALID_OPERATION is generated if <image_id> is not a valid image id.	52 INVALID_OPERATION is generated if <image_id> is not a valid image id.

53	53

54 Errors	54 Errors

55	55

56 None.	56 None.

57	57

58 New State	58 New State

59	59

60 None.	60 None.

61	61

62 Revision History	62 Revision History

63	63

64 5/9/2013 Documented the extension	64 5/9/2013 Documented the extension

65 4/30/2014 Moved usage flag to creation function.	65 4/30/2014 Moved usage flag to creation function.

66 10/7/2014 Remove map/unmap API.	66 10/7/2014 Remove map/unmap API.
	reveman 2015/04/01 23:38:55 And an entry here And an entry here Daniele Castagna 2015/04/03 01:08:15 Done. Show quoted text On 2015/04/01 at 23:38:55, reveman wrote: > And an entry here Done.
OLD	NEW