Move mod_pagespeed metrics out of prerender.

Move mod_pagespeed metrics out of prerender.

The metrics don't have much to do with prerender. Move them out into a
dedicated file.

BUG=none

Committed: https://crrev.com/f4877890bdacd8a446a24afba3043aa87da86471
Cr-Commit-Position: refs/heads/master@{#324358}

[davidben, 2015-03-31 19:33:22]

davidben@chromium.org changed reviewers:
+ sky@chromium.org

[davidben, 2015-03-31 19:33:23]

sky: I'm designating you as the primary reviewer if you don't mind. You have
OWNERS coverage, and the primary question is where to toss this thing. I didn't
make any changes apart from git cl format, renaming the function, and fixing up
a couple comments

I noticed this in the corner of prerender, but it has nothing to do with
prerender. The mod_pagespeed folks are apparently using it (though measuring
usage metrics this way seems off), so I figured I should at least move it
somewhere more sensible. I'm not sure where to put it. chrome/browser is a bit
of a dumping ground, so I just dumped it here. Wherever this goes is somewhat
doomed to be a dumping ground.

Other thoughts were c/b/metrics (asvitkine didn't think it belonged there) or
c/b/renderer_host since that's where it's used. I mildly prefer c/b over c/b/r_h
since c/b/r_h seems to just contain things that plug into content. But if you
prefer it or elsewhere, I'll defer to you.

[sky, 2015-03-31 23:51:55]

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
File chrome/browser/mod_pagespeed_metrics.cc (right):

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.cc:41: int a, b, c, d, e;
I realize you're just moving code, but since you're touching it you get
feedback. Please use descriptive names here. Also, using unused_ might be
helpful to indicate some fields aren't important.

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.cc:85: void* iter = NULL;
nullptr

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
File chrome/browser/mod_pagespeed_metrics.h (right):

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.h:5: #ifndef
CHROME_BROWSER_MOD_PAGESPEED_METRICS_H_
In hopes of not dumping more in chrome/browser, how about putting this in a
subdirectory, chrome/browser/mod_pagespeed?

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.h:16: // Records metrics about
mod_pagespeed headers.
Can you point to where one would look for what mod_pagespeed headers are?

[davidben, 2015-04-08 21:07:46]

The rename seems to have been unfriendly to the inter-patchset diff. Sorry. :-(

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
File chrome/browser/mod_pagespeed_metrics.cc (right):

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.cc:41: int a, b, c, d, e;
On 2015/03/31 23:51:55, sky wrote:
> I realize you're just moving code, but since you're touching it you get
> feedback. Please use descriptive names here. Also, using unused_ might be
> helpful to indicate some fields aren't important.

Done.

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.cc:85: void* iter = NULL;
On 2015/03/31 23:51:55, sky wrote:
> nullptr

Done.

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
File chrome/browser/mod_pagespeed_metrics.h (right):

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.h:5: #ifndef
CHROME_BROWSER_MOD_PAGESPEED_METRICS_H_
On 2015/03/31 23:51:55, sky wrote:
> In hopes of not dumping more in chrome/browser, how about putting this in a
> subdirectory, chrome/browser/mod_pagespeed?

Done.

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.h:16: // Records metrics about
mod_pagespeed headers.
On 2015/03/31 23:51:55, sky wrote:
> Can you point to where one would look for what mod_pagespeed headers are?

Done.

[davidben, 2015-04-08 21:07:46]

The rename seems to have been unfriendly to the inter-patchset diff. Sorry. :-(

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
File chrome/browser/mod_pagespeed_metrics.cc (right):

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.cc:41: int a, b, c, d, e;
On 2015/03/31 23:51:55, sky wrote:
> I realize you're just moving code, but since you're touching it you get
> feedback. Please use descriptive names here. Also, using unused_ might be
> helpful to indicate some fields aren't important.

Done.

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.cc:85: void* iter = NULL;
On 2015/03/31 23:51:55, sky wrote:
> nullptr

Done.

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
File chrome/browser/mod_pagespeed_metrics.h (right):

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.h:5: #ifndef
CHROME_BROWSER_MOD_PAGESPEED_METRICS_H_
On 2015/03/31 23:51:55, sky wrote:
> In hopes of not dumping more in chrome/browser, how about putting this in a
> subdirectory, chrome/browser/mod_pagespeed?

Done.

https://codereview.chromium.org/1051463003/diff/1/chrome/browser/mod_pagespee...
chrome/browser/mod_pagespeed_metrics.h:16: // Records metrics about
mod_pagespeed headers.
On 2015/03/31 23:51:55, sky wrote:
> Can you point to where one would look for what mod_pagespeed headers are?

Done.

[sky, 2015-04-09 00:06:42]

LGTM

[davidben, 2015-04-09 01:38:41]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2015-04-09 01:41:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1051463003/40001

[commit-bot: I haz the power, 2015-04-09 03:59:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-09 04:01:16]

Patchset 3 (id:??) landed as
https://crrev.com/f4877890bdacd8a446a24afba3043aa87da86471
Cr-Commit-Position: refs/heads/master@{#324358}