Improvements to the offline intersitial and easter egg

chrome/renderer/net/net_error_page_controller.cc

Index: chrome/renderer/net/net_error_page_controller.cc
diff --git a/chrome/renderer/net/net_error_page_controller.cc b/chrome/renderer/net/net_error_page_controller.cc
index c297a5ae4e61d192b04e95499a43c1e5a25b69e5..17b8dc9a6a776c0a44ce3a5b940095d053fe19fd 100644
--- a/chrome/renderer/net/net_error_page_controller.cc
+++ b/chrome/renderer/net/net_error_page_controller.cc
@@ -4,9 +4,11 @@
 
 #include "chrome/renderer/net/net_error_page_controller.h"
 
+#include "base/metrics/user_metrics_action.h"
 #include "base/strings/string_piece.h"
 #include "chrome/renderer/net/net_error_helper.h"
 #include "content/public/renderer/render_frame.h"
+#include "content/public/renderer/render_thread.h"
 #include "gin/handle.h"
 #include "gin/object_template_builder.h"
 #include "third_party/WebKit/public/web/WebKit.h"
@@ -86,6 +88,11 @@ bool NetErrorPageController::TrackClick(const gin::Arguments& args) {
   return true;
 }
 
+void NetErrorPageController::TrackEasterEgg() {
+  content::RenderThread::Get()->RecordAction(
+    base::UserMetricsAction("DinosaurEasterEgg"));

[mmenke, 2015/03/31 18:39:08]

nit:  +2 indent

[Alexei Svitkine (slow), 2015/03/31 19:08:40]

Is there a reason you're using an action and not a histogram here?

Histograms generally offer better support from our dashboards. For example, you
could have a histogram with two buckets, one tracking how many times the error
page was shown and another for the easter egg being activated - so you can get a
sense of what percent of users actually use it (rather than just absolute counts
which don't say much in a vacuum).

[edwardjung, 2015/04/01 10:40:46]

Good point. I dug in a but deeper and it turns out there is a network error
histogram set up. Missed it as it wrapped in multiple classes. Have updated the
code accordingly.

[edwardjung, 2015/04/01 10:40:46]

Done.

+}
+
 NetErrorPageController::NetErrorPageController(
     content::RenderFrame* render_frame) : RenderFrameObserver(render_frame) {}
 
@@ -102,7 +109,9 @@ gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder(
       .SetMethod("detailsButtonClick",
                  &NetErrorPageController::DetailsButtonClick)
       .SetMethod("trackClick",
-                 &NetErrorPageController::TrackClick);
+                 &NetErrorPageController::TrackClick)
+      .SetMethod("trackEasterEgg",
+                 &NetErrorPageController::TrackEasterEgg);
 }
 
 void NetErrorPageController::OnDestruct() {}