Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: chrome/renderer/net/net_error_page_controller.cc

Issue 1051433002: Improvements to the offline intersitial and easter egg (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Darn it, keep forgetting CrOS has a separate offline template! Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/net/net_error_page_controller.cc
diff --git a/chrome/renderer/net/net_error_page_controller.cc b/chrome/renderer/net/net_error_page_controller.cc
index c297a5ae4e61d192b04e95499a43c1e5a25b69e5..b44bf03010b18bbc9b319ab823bdbce878233149 100644
--- a/chrome/renderer/net/net_error_page_controller.cc
+++ b/chrome/renderer/net/net_error_page_controller.cc
@@ -86,6 +86,16 @@ bool NetErrorPageController::TrackClick(const gin::Arguments& args) {
return true;
}
+void NetErrorPageController::TrackEasterEgg() {
+ if (!render_frame())
+ return;
+
+ NetErrorHelper* net_error_helper =
+ content::RenderFrameObserverTracker<NetErrorHelper>::Get(render_frame());
+ DCHECK(net_error_helper);
+ net_error_helper->TrackActivatedEasterEgg();
+}
+
NetErrorPageController::NetErrorPageController(
content::RenderFrame* render_frame) : RenderFrameObserver(render_frame) {}
@@ -102,7 +112,9 @@ gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder(
.SetMethod("detailsButtonClick",
&NetErrorPageController::DetailsButtonClick)
.SetMethod("trackClick",
- &NetErrorPageController::TrackClick);
+ &NetErrorPageController::TrackClick)
+ .SetMethod("trackEasterEgg",
+ &NetErrorPageController::TrackEasterEgg);
}
void NetErrorPageController::OnDestruct() {}
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | chrome/renderer/resources/default_100_percent/offline/100-cloud.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698