Improvements to the offline intersitial and easter egg

chrome/renderer/net/net_error_page_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/net/net_error_page_controller.h"
 
+#include "base/metrics/user_metrics_action.h"
 #include "base/strings/string_piece.h"
 #include "chrome/renderer/net/net_error_helper.h"
 #include "content/public/renderer/render_frame.h"
+#include "content/public/renderer/render_thread.h"
 #include "gin/handle.h"
 #include "gin/object_template_builder.h"
 #include "third_party/WebKit/public/web/WebKit.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 
 gin::WrapperInfo NetErrorPageController::kWrapperInfo = {
     gin::kEmbedderNativeGin};
 
 // static
 void NetErrorPageController::Install(content::RenderFrame* render_frame) {
@@ skipping 59 matching lines @@
   if (!args.PeekNext()->IsInt32())
     return false;
 
   NetErrorHelper* net_error_helper =
       content::RenderFrameObserverTracker<NetErrorHelper>::Get(render_frame());
   DCHECK(net_error_helper);
   net_error_helper->TrackClick(args.PeekNext()->Int32Value());
   return true;
 }
 
+void NetErrorPageController::TrackEasterEgg() {
+  content::RenderThread::Get()->RecordAction(
+    base::UserMetricsAction("DinosaurEasterEgg"));

[mmenke, 2015/03/31 18:39:08]

nit:  +2 indent

[Alexei Svitkine (slow), 2015/03/31 19:08:40]

Is there a reason you're using an action and not a histogram here?

Histograms generally offer better support from our dashboards. For example, you
could have a histogram with two buckets, one tracking how many times the error
page was shown and another for the easter egg being activated - so you can get a
sense of what percent of users actually use it (rather than just absolute counts
which don't say much in a vacuum).

[edwardjung, 2015/04/01 10:40:46]

Good point. I dug in a but deeper and it turns out there is a network error
histogram set up. Missed it as it wrapped in multiple classes. Have updated the
code accordingly.

[edwardjung, 2015/04/01 10:40:46]

Done.

+}
+
 NetErrorPageController::NetErrorPageController(
     content::RenderFrame* render_frame) : RenderFrameObserver(render_frame) {}
 
 NetErrorPageController::~NetErrorPageController() {}
 
 gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder(
     v8::Isolate* isolate) {
   return gin::Wrappable<NetErrorPageController>::GetObjectTemplateBuilder(
              isolate)
       .SetMethod("showSavedCopyButtonClick",
                  &NetErrorPageController::ShowSavedCopyButtonClick)
       .SetMethod("reloadButtonClick",
                  &NetErrorPageController::ReloadButtonClick)
       .SetMethod("detailsButtonClick",
                  &NetErrorPageController::DetailsButtonClick)
       .SetMethod("trackClick",
-                 &NetErrorPageController::TrackClick);
+                 &NetErrorPageController::TrackClick)
+      .SetMethod("trackEasterEgg",
+                 &NetErrorPageController::TrackEasterEgg);
 }
 
 void NetErrorPageController::OnDestruct() {}