Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: components/error_page/renderer/net_error_helper_core.cc

Issue 1051433002: Improvements to the offline intersitial and easter egg (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Darn it, keep forgetting CrOS has a separate offline template! Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/error_page/renderer/net_error_helper_core.h" 5 #include "components/error_page/renderer/net_error_helper_core.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 904 matching lines...) Expand 10 before | Expand all | Expand 10 after
915 NETWORK_ERROR_PAGE_BOTH_BUTTONS_SHOWN_SAVED_COPY_CLICKED); 915 NETWORK_ERROR_PAGE_BOTH_BUTTONS_SHOWN_SAVED_COPY_CLICKED);
916 } 916 }
917 delegate_->LoadPageFromCache( 917 delegate_->LoadPageFromCache(
918 committed_error_page_info_->error.unreachableURL); 918 committed_error_page_info_->error.unreachableURL);
919 return; 919 return;
920 case MORE_BUTTON: 920 case MORE_BUTTON:
921 // Visual effects on page are handled in Javascript code. 921 // Visual effects on page are handled in Javascript code.
922 chrome_common_net::RecordEvent( 922 chrome_common_net::RecordEvent(
923 chrome_common_net::NETWORK_ERROR_PAGE_MORE_BUTTON_CLICKED); 923 chrome_common_net::NETWORK_ERROR_PAGE_MORE_BUTTON_CLICKED);
924 return; 924 return;
925 case EASTER_EGG:
926 chrome_common_net::RecordEvent(
927 chrome_common_net::NETWORK_ERROR_EASTER_EGG_ACTIVATED);
928 return;
925 case NO_BUTTON: 929 case NO_BUTTON:
926 NOTREACHED(); 930 NOTREACHED();
927 return; 931 return;
928 } 932 }
929 } 933 }
930 934
931 void NetErrorHelperCore::TrackClick(int tracking_id) { 935 void NetErrorHelperCore::TrackClick(int tracking_id) {
932 // It's technically possible for |navigation_correction_params| to be NULL but 936 // It's technically possible for |navigation_correction_params| to be NULL but
933 // for |navigation_correction_response| not to be NULL, if the paramters 937 // for |navigation_correction_response| not to be NULL, if the paramters
934 // changed between loading the original error page and loading the error page 938 // changed between loading the original error page and loading the error page
(...skipping 23 matching lines...) Expand all
958 committed_error_page_info_->error, 962 committed_error_page_info_->error,
959 *committed_error_page_info_->navigation_correction_params, 963 *committed_error_page_info_->navigation_correction_params,
960 *response, 964 *response,
961 *response->corrections[tracking_id]); 965 *response->corrections[tracking_id]);
962 delegate_->SendTrackingRequest( 966 delegate_->SendTrackingRequest(
963 committed_error_page_info_->navigation_correction_params->url, 967 committed_error_page_info_->navigation_correction_params->url,
964 request_body); 968 request_body);
965 } 969 }
966 970
967 } // namespace error_page 971 } // namespace error_page
OLDNEW
« no previous file with comments | « components/error_page/renderer/net_error_helper_core.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698