Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 105143009: Expose more SkPaint fields in Lua API. (Closed)

Created:
7 years ago by Tom Hudson
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Expose more SkPaint fields in Lua API. Adds getters (but not setters) for most SkPaint fields. R=reed@google.com,robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=12746

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -0 lines) Patch
M src/utils/SkLua.cpp View 1 6 chunks +108 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tomhudson
Patch set 1 had some incorrect-although-not-visibly-buggy types (scalar vs number vs U32), but PS2 seems ...
7 years ago (2013-12-18 17:49:30 UTC) #1
reed1
lgtm
7 years ago (2013-12-18 17:53:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/105143009/20001
7 years ago (2013-12-18 17:56:14 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-18 18:28:09 UTC) #4
Message was sent while issue was closed.
Change committed as 12746

Powered by Google App Engine
This is Rietveld 408576698