platform_tools/chromeos/bin/chromeos_setup.sh - Issue 1051423002: back to plain arm for the night

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/chromeos/bin/chromeos_setup.sh

Issue 1051423002: back to plain arm for the night (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/chromeos/bin/chromeos_setup.sh

diff --git a/platform_tools/chromeos/bin/chromeos_setup.sh b/platform_tools/chromeos/bin/chromeos_setup.sh

index 721d7d6c5341b3aff052d87a620ed02212c5a879..de4d6f99ca01e8d5846beb6dd1ecef3ea2eab603 100755

--- a/platform_tools/chromeos/bin/chromeos_setup.sh

+++ b/platform_tools/chromeos/bin/chromeos_setup.sh

@@ -34,8 +34,8 @@ setup_device() {

GENERIC_BOARD_TYPE="amd64-generic"

;;

daisy)

- # TODO(mtklein): make this arm_neon=1

- DEFINES="${DEFINES} skia_arch_type=arm arm_version=7 arm_neon=0"

+ # TODO(mtklein): make this arm_version=7 arm_neon=1

+ DEFINES="${DEFINES} skia_arch_type=arm"

# TODO(borenet): We have to define skia_warnings_as_errors=0 for the arm

# build, which throws lots of "mangling of va_list has changed" warnings.

DEFINES="${DEFINES} skia_warnings_as_errors=0"

« no previous file with comments | « no previous file | no next file » | no next file with comments »