Issue 1051413003: extensions: Reuse crx_file's HashedIdInHex() function in SimpleFeature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1051413003: extensions: Reuse crx_file's HashedIdInHex() function in SimpleFeature. (Closed)

Created:
5 years, 8 months ago by tfarina

Modified:
5 years, 8 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Ilya Sherman, James Cook, Yoyo Zhou

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

extensions: Reuse crx_file's HashedIdInHex() function in SimpleFeature. The implementation of HashExtensionId() is identical to the one in id_util.h BUG=384613 TEST=extensions_unittests R=rockot@chromium.org Committed: https://crrev.com/a1e804d26dd14e7baa983b3de52f0da1d9c9b3c1 Cr-Commit-Position: refs/heads/master@{#323881}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	extensions/common/features/simple_feature.cc	View		4 chunks	+5 lines, -8 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051413003/1

5 years, 8 months ago (2015-04-04 14:18:51 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-04 14:36:27 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a1e804d26dd14e7baa983b3de52f0da1d9c9b3c1
Cr-Commit-Position: refs/heads/master@{#323881}