Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1051393003: Removed src/{isolate,property-details,utils}-inl.h (Closed)

Created:
5 years, 8 months ago by Sven Panne
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed src/{isolate,property-details,utils}-inl.h Baby steps towards saner #includes... Committed: https://crrev.com/4d3044e161b0a04aa19079cb8580d7e0e9b9413c Cr-Commit-Position: refs/heads/master@{#27958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -151 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/api-natives.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/assert-scope.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 6 chunks +19 lines, -10 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 3 chunks +24 lines, -1 line 0 comments Download
D src/isolate-inl.h View 1 chunk +0 lines, -42 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/preparse-data.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/property-details.h View 1 chunk +0 lines, -2 lines 0 comments Download
D src/property-details-inl.h View 1 chunk +0 lines, -27 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/utils.h View 1 chunk +8 lines, -1 line 0 comments Download
D src/utils-inl.h View 1 chunk +0 lines, -25 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-random-number-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-types.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/test-utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 8 months ago (2015-04-21 09:58:20 UTC) #2
dcarney
lgtm
5 years, 8 months ago (2015-04-21 10:02:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051393003/1
5 years, 8 months ago (2015-04-21 10:18:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 10:21:58 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 10:22:14 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4d3044e161b0a04aa19079cb8580d7e0e9b9413c
Cr-Commit-Position: refs/heads/master@{#27958}

Powered by Google App Engine
This is Rietveld 408576698