Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1051373002: ES6: Number and Boolean prototype should be ordinary objects (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 8 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ES6: Number and Boolean prototype should be ordinary objects BUG=v8:4001 LOG=N R=adamk@chromium.org, rossberg@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/e965a1f84a7a4024d40680ef63e82abeaef867fd Cr-Commit-Position: refs/heads/master@{#27680}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Add mozilla.status exceptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -55 lines) Patch
M src/v8natives.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A test/mjsunit/es6/prototype-ordinary-objects.js View 1 chunk +64 lines, -0 lines 0 comments Download
M test/mozilla/mozilla.status View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M test/test262-es6/test262-es6.status View 2 chunks +0 lines, -53 lines 0 comments Download
M test/test262/test262.status View 1 2 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
arv (Not doing code reviews)
PTAL
5 years, 8 months ago (2015-04-02 19:16:52 UTC) #1
adamk
lgtm
5 years, 8 months ago (2015-04-02 19:18:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051373002/40001
5 years, 8 months ago (2015-04-08 13:40:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/4565)
5 years, 8 months ago (2015-04-08 14:13:18 UTC) #6
arv (Not doing code reviews)
Add mozilla.status exceptions
5 years, 8 months ago (2015-04-08 18:50:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051373002/60001
5 years, 8 months ago (2015-04-08 18:51:06 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-08 21:18:38 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 21:18:50 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e965a1f84a7a4024d40680ef63e82abeaef867fd
Cr-Commit-Position: refs/heads/master@{#27680}

Powered by Google App Engine
This is Rietveld 408576698