Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1051363004: Drop ScriptState argument from global Cache Storage accessor. (Closed)

Created:
5 years, 8 months ago by jsbell
Modified:
5 years, 8 months ago
Reviewers:
dmurph
CC:
blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop ScriptState argument from global Cache Storage accessor. We only need an ExecutionContext and that can be obtained from the global scope that is implicitly passed in. Simplifies the IDL. R=dmurph@chromium.org BUG=439389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M Source/modules/serviceworkers/GlobalCacheStorage.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/GlobalCacheStorage.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/serviceworkers/WindowCacheStorage.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/WorkerCacheStorage.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051363004/1
5 years, 8 months ago (2015-04-03 00:22:57 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/30445)
5 years, 8 months ago (2015-04-03 00:38:14 UTC) #4
dmurph
lgtm
5 years, 8 months ago (2015-04-03 00:47:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051363004/1
5 years, 8 months ago (2015-04-03 01:17:32 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 03:48:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193068

Powered by Google App Engine
This is Rietveld 408576698