Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1051343005: Add covariant overrides to TestRVH::GetProcess and TestRFH::GetProcess (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@unittest_frame_liveness
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add covariant overrides to TestRVH::GetProcess and TestRFH::GetProcess that return the MockRenderProcessHost. Preamble to a fix for bug 474231, where I'll add a new method to MockRenderProcessHost. BUG=474231 Committed: https://crrev.com/ddc9d534d87919f4a7211fb34086628914f55b7c Cr-Commit-Position: refs/heads/master@{#325472}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/navigator_impl_unittest.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/test/test_render_frame_host.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/test/test_render_frame_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/test_render_view_host.h View 3 chunks +6 lines, -2 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
Nasko, please take a look
5 years, 8 months ago (2015-04-15 22:44:55 UTC) #2
nasko
LGTM
5 years, 8 months ago (2015-04-16 14:06:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051343005/20001
5 years, 8 months ago (2015-04-16 16:55:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 17:46:36 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 17:47:35 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ddc9d534d87919f4a7211fb34086628914f55b7c
Cr-Commit-Position: refs/heads/master@{#325472}

Powered by Google App Engine
This is Rietveld 408576698