Add junit tests for //base/android

Add junit tests for //base/android

Adds a gyp and gn build target: base_junit_tests
Adds test suite: base_junit_tests

Depends on https://codereview.chromium.org/1048153002/
BUG=448030, 472152
Committed: https://crrev.com/c0c058979a1a452f16271eb134246fd79f5023fa
Cr-Commit-Position: refs/heads/master@{#326861}

[dgn, 2015-04-02 17:46:58]

mikecase@: PTAL. I tested gyp only for now. I'm investigating why my GN build
fails.

[mikecase (-- gone --), 2015-04-02 17:52:35]

On 2015/04/02 17:46:58, dgn wrote:
> mikecase@: PTAL. I tested gyp only for now. I'm investigating why my GN build
> fails.

I have a fix for GN (https://codereview.chromium.org/1057783002/). It also adds
a new junit_binary template which adds the junit dependencies and sets some of
the build variables (like testonly=true), so your BUILD.gn file will become
this.

junit_binary("base_junit_tests") {
  java_files = [ "android/junit/src/org/chromium/base/LogTest.java" ]
  deps = [
    ":base_java",
    ":base_java_test_support",
  ]
}

[dgn, 2015-04-02 18:10:22]

On 2015/04/02 17:52:35, mikecase wrote:
> On 2015/04/02 17:46:58, dgn wrote:
> > mikecase@: PTAL. I tested gyp only for now. I'm investigating why my GN
build
> > fails.
> 
> I have a fix for GN (https://codereview.chromium.org/1057783002/). It also
adds
> a new junit_binary template which adds the junit dependencies and sets some of
> the build variables (like testonly=true), so your BUILD.gn file will become
> this.
> 
> junit_binary("base_junit_tests") {
>   java_files = [ "android/junit/src/org/chromium/base/LogTest.java" ]
>   deps = [
>     ":base_java",
>     ":base_java_test_support",
>   ]
> }

Great, thanks! I'll rebase once it's landed. I also need to wait until the CL
adding Log lands anyway.

[mikecase (-- gone --), 2015-04-07 22:56:40]

On 2015/04/02 18:10:22, dgn wrote:
> On 2015/04/02 17:52:35, mikecase wrote:
> > On 2015/04/02 17:46:58, dgn wrote:
> > > mikecase@: PTAL. I tested gyp only for now. I'm investigating why my GN
> build
> > > fails.
> > 
> > I have a fix for GN (https://codereview.chromium.org/1057783002/). It also
> adds
> > a new junit_binary template which adds the junit dependencies and sets some
of
> > the build variables (like testonly=true), so your BUILD.gn file will become
> > this.
> > 
> > junit_binary("base_junit_tests") {
> >   java_files = [ "android/junit/src/org/chromium/base/LogTest.java" ]
> >   deps = [
> >     ":base_java",
> >     ":base_java_test_support",
> >   ]
> > }
> 
> Great, thanks! I'll rebase once it's landed. I also need to wait until the CL
> adding Log lands anyway.

CL landed, try building with GN using the junit template (like I wrote out
above) and tell me if you have any problems.

[dgn, 2015-04-08 10:20:45]

On 2015/04/07 22:56:40, mikecase wrote:
> On 2015/04/02 18:10:22, dgn wrote:
> > On 2015/04/02 17:52:35, mikecase wrote:
> > > On 2015/04/02 17:46:58, dgn wrote:
> > > > mikecase@: PTAL. I tested gyp only for now. I'm investigating why my GN
> > build
> > > > fails.
> > > 
> > > I have a fix for GN (https://codereview.chromium.org/1057783002/). It also
> > adds
> > > a new junit_binary template which adds the junit dependencies and sets
some
> of
> > > the build variables (like testonly=true), so your BUILD.gn file will
become
> > > this.
> > > 
> > > junit_binary("base_junit_tests") {
> > >   java_files = [ "android/junit/src/org/chromium/base/LogTest.java" ]
> > >   deps = [
> > >     ":base_java",
> > >     ":base_java_test_support",
> > >   ]
> > > }
> > 
> > Great, thanks! I'll rebase once it's landed. I also need to wait until the
CL
> > adding Log lands anyway.
> 
> CL landed, try building with GN using the junit template (like I wrote out
> above) and tell me if you have any problems.

Thanks, it worked perfectly! Well, except for this message I get at every run:
WARNING: no system properties value for ro.build.date.utc

Are the bots running unit tests? Do I need to do something to add it?

[dgn, 2015-04-09 09:00:02]

dgn@chromium.org changed reviewers:
+ danakj@chromium.org

[dgn, 2015-04-09 09:00:03]

Please take a look when you have a moment. It adds junit tests for base and a
test for Log.java built on this.

[dgn, 2015-04-24 17:58:41]

dgn@chromium.org changed reviewers:
+ yfriedman@chromium.org

[dgn, 2015-04-24 17:58:42]

yfriedman@: Can you please have a look at
base/android/junit/src/org/chromium/base/LogTest.java? 

Thanks

[Yaron, 2015-04-24 18:34:48]

lgtm with one comment.

First roboelectric test I've reviewed - shadows are pretty awesome!

https://codereview.chromium.org/1051343002/diff/40001/base/android/junit/src/...
File base/android/junit/src/org/chromium/base/LogTest.java (right):

https://codereview.chromium.org/1051343002/diff/40001/base/android/junit/src/...
base/android/junit/src/org/chromium/base/LogTest.java:40:
assertTrue(logs.get(0).msg.startsWith(
Hmm. I'm a little torn about this. While this isn't brittle by hard-coding a
line number, in general test assertions shouldn't have much logic (cause they
could have a bug masking a bug in the real code).

wdyt about changing this to:
assertTrue(logs.get(0).msg.matches("[LogTest.java:\d+].*") 

Also, outputting logs.get(0).msg would be helpful in the failure message.

[dgn, 2015-04-24 19:04:29]

Thanks for the review! Robolectric is great yes! (Well, as long as there is not
too many static methods involved).

danakj@ could you please have a look?

https://codereview.chromium.org/1051343002/diff/40001/base/android/junit/src/...
File base/android/junit/src/org/chromium/base/LogTest.java (right):

https://codereview.chromium.org/1051343002/diff/40001/base/android/junit/src/...
base/android/junit/src/org/chromium/base/LogTest.java:40:
assertTrue(logs.get(0).msg.startsWith(
On 2015/04/24 18:34:48, Yaron wrote:
> Hmm. I'm a little torn about this. While this isn't brittle by hard-coding a
> line number, in general test assertions shouldn't have much logic (cause they
> could have a bug masking a bug in the real code).
> 
> wdyt about changing this to:
> assertTrue(logs.get(0).msg.matches("[LogTest.java:\d+].*") 
> 
> Also, outputting logs.get(0).msg would be helpful in the failure message.

Good point. If I don't get the right frame I will not be in the same file anyway
so that's a good enough check.

[danakj, 2015-04-24 19:08:16]

LGTM

[dgn, 2015-04-24 19:08:41]

The CQ bit was checked by dgn@chromium.org

[dgn, 2015-04-24 19:08:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1051343002/#ps60001
(title: "Rewrote callOriginTest to use a regex instead of getting a second stack
trace")

[commit-bot: I haz the power, 2015-04-24 19:09:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1051343002/60001

[commit-bot: I haz the power, 2015-04-24 20:09:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-24 20:11:34]

Patchset 4 (id:??) landed as
https://crrev.com/c0c058979a1a452f16271eb134246fd79f5023fa
Cr-Commit-Position: refs/heads/master@{#326861}