Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1051303003: [win32] Improve random mmap address generation on 64-bit. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[win32] Improve random mmap address generation on 64-bit. Currently we only generate addresses in the range 2GiB to 4GiB, because of a bug, when running in 64-bit mode. With this fix we now use the full range 2GiB to 4096GiB. BUG=v8:3997 LOG=n R=svenpanne@chromium.org Committed: https://crrev.com/ee73c6f3e756ec2e67ee721761a53f60c3d544d8 Cr-Commit-Position: refs/heads/master@{#27610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/base/platform/platform-win32.cc View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-07 06:17:08 UTC) #1
Benedikt Meurer
Hey Sven, Following your suggestions, this should fix the issue. Please take a look. Thanks, ...
5 years, 8 months ago (2015-04-07 06:17:51 UTC) #2
Sven Panne
lgtm
5 years, 8 months ago (2015-04-07 06:38:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051303003/1
5 years, 8 months ago (2015-04-07 07:11:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 07:13:57 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 07:14:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee73c6f3e756ec2e67ee721761a53f60c3d544d8
Cr-Commit-Position: refs/heads/master@{#27610}

Powered by Google App Engine
This is Rietveld 408576698