Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1051273009: Correct ChildAccountService child flag retrieval (Closed)

Created:
5 years, 8 months ago by bartfab (slow)
Modified:
5 years, 8 months ago
Reviewers:
Marc Treib, merkulova
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct ChildAccountService child flag retrieval This CL fixes two bugs in ChildAccountService's child flag retrieval: * When flag fetching is disabled by command-line flag, causing all accounts to be marked as non-child, the flag status should be set to "known," not "unknown." * When the flag is retrieved from the cloud, it should be stored before notifying callbacks waiting for the retrieval to finish. This CL is a prerequisite for the test in crbug.com/477145. BUG=477145 TEST=Tested as part of the new browser test in follow-up CL Committed: https://crrev.com/fa8233aa24f47afdac436ad7340ef14a31263413 Cr-Commit-Position: refs/heads/master@{#326058}

Patch Set 1 #

Patch Set 2 : Add const. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M chrome/browser/supervised_user/child_accounts/child_account_service.cc View 1 2 chunks +12 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bartfab (slow)
Hi Tatiana, Please take a look.
5 years, 8 months ago (2015-04-21 15:36:18 UTC) #2
merkulova
lgtm
5 years, 8 months ago (2015-04-21 15:38:34 UTC) #3
bartfab (slow)
Hi Marc, Please take a look.
5 years, 8 months ago (2015-04-21 15:42:38 UTC) #5
Marc Treib
On 2015/04/21 15:42:38, bartfab wrote: > Hi Marc, > > Please take a look. LGTM, ...
5 years, 8 months ago (2015-04-21 15:59:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051273009/20001
5 years, 8 months ago (2015-04-21 16:16:09 UTC) #9
bartfab (slow)
On 2015/04/21 15:59:02, Marc Treib wrote: > On 2015/04/21 15:42:38, bartfab wrote: > > Hi ...
5 years, 8 months ago (2015-04-21 16:18:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 17:11:49 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 17:12:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa8233aa24f47afdac436ad7340ef14a31263413
Cr-Commit-Position: refs/heads/master@{#326058}

Powered by Google App Engine
This is Rietveld 408576698