Issue 1051273006: Card unmasking prompt - add accessibility for checkbox tooltip

Issue 1051273006: Card unmasking prompt - add accessibility for checkbox tooltip (Closed)

Created:
5 years, 8 months ago by Evan Stade

Modified:
5 years, 8 months ago

Reviewers:
dmazzoni, David Tseng, newt (away)

CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Card unmasking prompt - add accessibility for checkbox tooltip BUG=473283 Committed: https://crrev.com/82ad942a729379cdaf49f9d6ebd590411331cb06 Cr-Commit-Position: refs/heads/master@{#323915}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/android/java/res/layout/autofill_card_unmask_prompt.xml	View		3 chunks	+1 line, -3 lines	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 11 (3 generated)

Evan Stade

On 2015/04/02 23:51:37, Evan Stade wrote: > +dmazzoni for a11y review > +newt for owners ...

5 years, 8 months ago (2015-04-03 18:32:21 UTC) #3

newt (away)

lgtm, though Dominic might have thoughts about whether announceForAccessibility() is an appropriate option here

5 years, 8 months ago (2015-04-03 18:35:27 UTC) #4

dmazzoni

lgtm It sounds like a tooltip appears when you click on the CVV button, and ...

5 years, 8 months ago (2015-04-04 06:13:35 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051273006/1

5 years, 8 months ago (2015-04-06 17:43:14 UTC) #9

commit-bot: I haz the power

5 years, 8 months ago (2015-04-06 18:35:24 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/82ad942a729379cdaf49f9d6ebd590411331cb06
Cr-Commit-Position: refs/heads/master@{#323915}