src/pdf/SkPDFTypes.cpp - Issue 1051273004: Avoid defining snprintf when MSVC provides it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFTypes.cpp

Issue 1051273004: Avoid defining snprintf when MSVC provides it Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFTypes.cpp

diff --git a/src/pdf/SkPDFTypes.cpp b/src/pdf/SkPDFTypes.cpp

index e80d1186c38dc3e507604dd239e8570eec3653b0..87964c3e57defe0f4eaa7c0b2bfd5a569a0cd611 100644

--- a/src/pdf/SkPDFTypes.cpp

+++ b/src/pdf/SkPDFTypes.cpp

@@ -10,7 +10,7 @@

#include "SkPDFTypes.h"

#include "SkStream.h"

-#ifdef SK_BUILD_FOR_WIN

+#if defined(_MSC_VER) && _MSC_VER < 1900

#define SNPRINTF _snprintf

#else

#define SNPRINTF snprintf

« no previous file with comments | « src/core/SkString.cpp ('k') | no next file » | no next file with comments »