Issue 1051253003: The Push Messaging browser tests should use matchAll() rather than getAll()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1051253003: The Push Messaging browser tests should use matchAll() rather than getAll() (Closed)

Created:
5 years, 8 months ago by Peter Beverloo

Modified:
5 years, 8 months ago

Reviewers:
johnme, Kunihiko Sakamoto

CC:
chromium-reviews, peter+watch_chromium.org, johnme+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

The Push Messaging browser tests should use matchAll() rather than getAll() The getAll() function is being deprecated in favor of matchAll(), so update our tests to match the new name. R=johnme@chromium.org, ksakamoto@chromium.org BUG=473072 Committed: https://crrev.com/53d180fb6f0a8bbbd524ffc37e5eade429a8ee31 Cr-Commit-Position: refs/heads/master@{#323530}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/data/push_messaging/service_worker.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051253003/1

5 years, 8 months ago (2015-04-02 17:15:22 UTC) #4

Kunihiko Sakamoto

On 2015/04/02 17:33:48, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) Thanks!

5 years, 8 months ago (2015-04-03 00:37:23 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-03 20:27:29 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/53d180fb6f0a8bbbd524ffc37e5eade429a8ee31
Cr-Commit-Position: refs/heads/master@{#323530}