Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1051243003: Revert of Change V8 to branch 4.3 for M43 (Closed)

Created:
5 years, 8 months ago by mfomitchev
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change V8 to branch 4.3 for M43 (patchset #2 id:20001 of https://codereview.chromium.org/1052993002/) Reason for revert: There is a compile failure on WebKit Win Builder (dbg) http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/69606 All other CLs that went in look fairly innocuous, this is the only one that looks suspect, so I am going to revert. Apologies if this is a mistake. Original issue's description: > Change V8 to branch 4.3 for M43 > > R=jkummerov@chromium.org, machenbach@chromium.org > BUG= TBR=jkummerov@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/da5d9a454a01bd1ecc0248a874e8fd8a0e635390 Cr-Commit-Position: refs/heads/master@{#323531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mfomitchev
Created Revert of Change V8 to branch 4.3 for M43
5 years, 8 months ago (2015-04-02 17:32:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051243003/1
5 years, 8 months ago (2015-04-02 17:33:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 17:34:48 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:27:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da5d9a454a01bd1ecc0248a874e8fd8a0e635390
Cr-Commit-Position: refs/heads/master@{#323531}

Powered by Google App Engine
This is Rietveld 408576698