Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1051213006: Fix flow control enforcement condition. (Closed)

Created:
5 years, 8 months ago by Bence
Modified:
5 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flow control enforcement condition. The receiving window as known and obeyed by the peer is |unacked_recv_window_bytes_| less than |recv_window_size_|, this should be reflected in the check in DecreaseRecvWindowSize(). Otherwise |DCHECK_GE(recv_window_size_, unacked_recv_window_bytes_)| might fail in IncreaseRecvWindowSize(). This CL fixes that in both SpdySession and SpdyStream. BUG=478836 Committed: https://crrev.com/2fc6a45506266335ff1fec2bf9a58f896ea7cf43 Cr-Commit-Position: refs/heads/master@{#327285}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add regression tests. #

Patch Set 4 : Change error code. #

Total comments: 2

Patch Set 5 : s/packet/data frame/g #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -9 lines) Patch
M net/spdy/spdy_session.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 2 3 4 1 chunk +146 lines, -0 lines 0 comments Download
M net/spdy/spdy_stream.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Bence
Ryan, PTAL. Mille grazie.
5 years, 8 months ago (2015-04-17 17:35:11 UTC) #2
Ryan Hamilton
I suspect we should have a regression test for this.
5 years, 8 months ago (2015-04-17 17:42:11 UTC) #3
Bence
Ryan, PTAL. Thank you.
5 years, 8 months ago (2015-04-24 13:49:04 UTC) #4
Ryan Hamilton
LGTM, mod a nit in the test. https://codereview.chromium.org/1051213006/diff/60001/net/spdy/spdy_session_unittest.cc File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1051213006/diff/60001/net/spdy/spdy_session_unittest.cc#newcode3716 net/spdy/spdy_session_unittest.cc:3716: const int32 ...
5 years, 8 months ago (2015-04-27 15:27:18 UTC) #5
Bence
Thank you. https://codereview.chromium.org/1051213006/diff/60001/net/spdy/spdy_session_unittest.cc File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1051213006/diff/60001/net/spdy/spdy_session_unittest.cc#newcode3716 net/spdy/spdy_session_unittest.cc:3716: const int32 second_packet_size = 400; On 2015/04/27 ...
5 years, 7 months ago (2015-04-28 13:33:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051213006/80001
5 years, 7 months ago (2015-04-28 13:33:31 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-04-28 14:42:39 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 14:44:30 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2fc6a45506266335ff1fec2bf9a58f896ea7cf43
Cr-Commit-Position: refs/heads/master@{#327285}

Powered by Google App Engine
This is Rietveld 408576698