Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: src/zone.cc

Issue 1051213005: Fix DCHECK with unsigned int in zone.cc. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/zone.h" 5 #include "src/zone.h"
6 6
7 #include <cstring> 7 #include <cstring>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 V8::FatalProcessOutOfMemory("Zone"); 257 V8::FatalProcessOutOfMemory("Zone");
258 return nullptr; 258 return nullptr;
259 } 259 }
260 260
261 // Recompute 'top' and 'limit' based on the new segment. 261 // Recompute 'top' and 'limit' based on the new segment.
262 Address result = RoundUp(segment->start(), kAlignment); 262 Address result = RoundUp(segment->start(), kAlignment);
263 position_ = result + size; 263 position_ = result + size;
264 // Check for address overflow. 264 // Check for address overflow.
265 // (Should not happen since the segment is guaranteed to accomodate 265 // (Should not happen since the segment is guaranteed to accomodate
266 // size bytes + header and alignment padding) 266 // size bytes + header and alignment padding)
267 DCHECK_GE(reinterpret_cast<uintptr_t>(position_), 267 DCHECK(reinterpret_cast<uintptr_t>(position_) >=
268 reinterpret_cast<uintptr_t>(result)); 268 reinterpret_cast<uintptr_t>(result));
269 limit_ = segment->end(); 269 limit_ = segment->end();
270 DCHECK(position_ <= limit_); 270 DCHECK(position_ <= limit_);
271 return result; 271 return result;
272 } 272 }
273 273
274 } // namespace internal 274 } // namespace internal
275 } // namespace v8 275 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698