Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Issue 1051203002: Add a UMA to measure the amount of memory consumed in PartitionAlloc (Closed)

Created:
5 years, 8 months ago by haraken
Modified:
5 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a UMA to measure the amount of memory consumed in PartitionAlloc This UMA will be used in https://codereview.chromium.org/1053793004/. BUG=471650 Committed: https://crrev.com/aa6d6c6545d6322c2b82d5a132e7aa59910abfbe Cr-Commit-Position: refs/heads/master@{#323690}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
haraken
PTAL
5 years, 8 months ago (2015-04-02 12:32:01 UTC) #2
Ilya Sherman
https://codereview.chromium.org/1051203002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1051203002/diff/1/tools/metrics/histograms/histograms.xml#newcode24856 tools/metrics/histograms/histograms.xml:24856: + <summary>The committed memory size in PartitionAlloc.</summary> Please document ...
5 years, 8 months ago (2015-04-02 17:10:04 UTC) #3
haraken
Thanks for review! > https://codereview.chromium.org/1051203002/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (right): > > https://codereview.chromium.org/1051203002/diff/1/tools/metrics/histograms/histograms.xml#newcode24856 > tools/metrics/histograms/histograms.xml:24856: + ...
5 years, 8 months ago (2015-04-02 23:35:33 UTC) #4
Ilya Sherman
LGTM
5 years, 8 months ago (2015-04-03 01:01:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051203002/20001
5 years, 8 months ago (2015-04-03 04:43:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-03 08:04:05 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:35:24 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa6d6c6545d6322c2b82d5a132e7aa59910abfbe
Cr-Commit-Position: refs/heads/master@{#323690}

Powered by Google App Engine
This is Rietveld 408576698