Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1051193002: Update tz db to 2015b (Closed)

Created:
5 years, 8 months ago by jungshik at Google
Modified:
5 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update tz db to 2015b 1. Update the IANA tz db to 2015b. - http://mm.icann.org/pipermail/tz-announce/2015-March/000029.html - Mongolia decided to observe DST again in 2015 starting on the last Sunday in March. - Palestine's DST start date is corrected to be March 28 instead of 27th. 2. Add a script to download the tz database files (update_tz.sh) 3. Check in scripts/make_n_copy_data.sh that I've been using to build ICU data/assembly files and update README.chromium. 4. Update android/patch_locale.sh to apply android/brkitr.patch as well. BUG=473288 TEST=1. In JavaScript console, run the following. mar27_2015_1200 = new Date("03/27/2015 12:00Z") mar28_2015_1200 = new Date("03/28/2015 12:00Z") mar27_2015_1200.toLocaleString("en", {timeZone: "Asia/Gaza"} mar28_2015_1200.toLocaleString("en", {timeZone: "Asia/Gaza"} apr15_2014_1200 = new Date("04/15/2014 12:00Z") apr15_2015_1200 = new Date("04/15/2015 12:00Z") apr15_2014_1200.toLocaleString("en", {timeZone: "Asia/Ulan_Bator"} apr15_2015_1200.toLocaleString("en", {timeZone: "Asia/Ulan_Bator"} In Asia/Gaza, Mar 27 12:00Z should be 2PM and mar28 12:00Z should be 3PM. In Asia/Ulan_Bator, April 15 12:00Z should be 8PM in 2014 and should be 9PM in 2015. Ulan_Bator does not work due to http://crbug.com/364374. R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/5f18004f45d42011719f0cb98e70a6f8f0c9f353

Patch Set 1 #

Patch Set 2 : add pre-built data/assembly files #

Patch Set 3 : windows dll #

Patch Set 4 : add copyright stmnt to scripts #

Patch Set 5 : add comments to update_tz.sh #

Total comments: 14

Patch Set 6 : review comments addressed #

Total comments: 2

Patch Set 7 : quote for $0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -69 lines) Patch
M README.chromium View 1 2 3 4 5 6 3 chunks +17 lines, -9 lines 0 comments Download
M android/icudtl.dat View Binary file 0 comments Download
M android/patch_locale.sh View 1 2 3 4 5 6 1 chunk +6 lines, -1 line 0 comments Download
A scripts/make_n_copy_data.sh View 1 2 3 4 5 6 1 chunk +25 lines, -0 lines 0 comments Download
A scripts/update_tz.sh View 1 2 3 4 5 6 1 chunk +36 lines, -0 lines 0 comments Download
M source/data/in/icudtl.dat View Binary file 0 comments Download
M source/data/misc/windowsZones.txt View 2 3 4 5 6 2 chunks +4 lines, -1 line 0 comments Download
M source/data/misc/zoneinfo64.txt View 2 3 4 5 6 15 chunks +53 lines, -58 lines 0 comments Download
M windows/icudt.dll View Binary file 0 comments Download

Messages

Total messages: 7 (1 generated)
jungshik at Google
PTAL. Thanks
5 years, 8 months ago (2015-04-02 19:35:23 UTC) #2
Mark Mentovai
https://codereview.chromium.org/1051193002/diff/50001/android/patch_locale.sh File android/patch_locale.sh (right): https://codereview.chromium.org/1051193002/diff/50001/android/patch_locale.sh#newcode18 android/patch_locale.sh:18: cd $(dirname $0)/.. cd "$(dirname "$0")/.." https://codereview.chromium.org/1051193002/diff/50001/scripts/make_n_copy_data.sh File scripts/make_n_copy_data.sh ...
5 years, 8 months ago (2015-04-02 19:47:11 UTC) #3
jungshik at Google
Thank you for looking. Can you take another look? I addressed review comments. https://codereview.chromium.org/1051193002/diff/50001/android/patch_locale.sh File ...
5 years, 8 months ago (2015-04-02 21:21:06 UTC) #4
Mark Mentovai
LGTM https://codereview.chromium.org/1051193002/diff/60001/android/patch_locale.sh File android/patch_locale.sh (right): https://codereview.chromium.org/1051193002/diff/60001/android/patch_locale.sh#newcode18 android/patch_locale.sh:18: cd "$(dirname $0)/.." "$0" in quotes also.
5 years, 8 months ago (2015-04-02 21:23:32 UTC) #5
jungshik at Google
Thanks. Landing now. https://codereview.chromium.org/1051193002/diff/60001/android/patch_locale.sh File android/patch_locale.sh (right): https://codereview.chromium.org/1051193002/diff/60001/android/patch_locale.sh#newcode18 android/patch_locale.sh:18: cd "$(dirname $0)/.." On 2015/04/02 21:23:32, ...
5 years, 8 months ago (2015-04-02 21:44:17 UTC) #6
jungshik at Google
5 years, 8 months ago (2015-04-02 21:45:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #7 (id:70001) manually as
5f18004f45d42011719f0cb98e70a6f8f0c9f353 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698