Add controls to buildbot dashboard

Add controls to buildbot dashboard

BUG=skia:3603
Committed: https://skia.googlesource.com/buildbot/+/34567289359f9b62acbfd4cc4028ae82d304b296

[borenet, 2015-04-02 11:59:24]

borenet@google.com changed reviewers:
+ jcgregorio@google.com

[borenet, 2015-04-02 11:59:26]

This supersedes https://codereview.chromium.org/1045393002/ ("buildbot
dashboard: Add time period selector")

[borenet, 2015-04-02 12:01:02]

On 2015/04/02 11:59:26, borenet wrote:
> This supersedes https://codereview.chromium.org/1045393002/ ("buildbot
> dashboard: Add time period selector")

Staged (for now) here: http://nautilus.cnc.corp.google.com:8000/buildbots

[rmistry, 2015-04-02 14:33:12]

rmistry@google.com changed reviewers:
+ rmistry@google.com

[rmistry, 2015-04-02 14:33:12]

I will let Joe review in depth.

A few thoughts after playing with the staged code:
* This is an example of what the time looks like:
  "Time (s): 76411.18485188484"
  Could we instead display something like 3hr 13min, I am sure there is a
library available somewhere that does this.
* Would it be useful if the builder names were clickable?
* I see many steps show up at the bottom with no red bar, is there a red bar but
its too small to click? or is there no red bar? should be we displaying things
if there is no red bar.

[jcgregorio, 2015-04-02 14:36:56]

On 2015/04/02 at 14:33:12, rmistry wrote:
> I will let Joe review in depth.
> 
> A few thoughts after playing with the staged code:
> * This is an example of what the time looks like:
>   "Time (s): 76411.18485188484"
>   Could we instead display something like 3hr 13min, I am sure there is a
library available somewhere that does this.

http://golang.org/pkg/time/#Duration.String does that.

On the JS side sk.human.DiffDate does something similar:

  https://github.com/google/skia-buildbot/blob/master/res/js/common.js#L208

> * Would it be useful if the builder names were clickable?

+1

> * I see many steps show up at the bottom with no red bar, is there a red bar
but its too small to click? or is there no red bar? should be we displaying
things if there is no red bar.

[borenet, 2015-04-02 14:37:05]

On 2015/04/02 14:33:12, rmistry wrote:
> I will let Joe review in depth.
> 
> A few thoughts after playing with the staged code:
> * This is an example of what the time looks like:
>   "Time (s): 76411.18485188484"
>   Could we instead display something like 3hr 13min, I am sure there is a
> library available somewhere that does this.

Agreed, but I don't know how much control I have over that since I'm using the
chart library and not writing the labels myself.

> * Would it be useful if the builder names were clickable?

Yeah, the next step will be to display a popup with another graph of the steps
running on that builder.

> * I see many steps show up at the bottom with no red bar, is there a red bar
but
> its too small to click? or is there no red bar? should be we displaying things
> if there is no red bar.

Those are values that are so small relative to the largest value that they don't
show any bar.  If you filter out the large values, eg. Valgrind, they show up.

[jcgregorio, 2015-04-02 14:43:14]

https://codereview.chromium.org/1051173003/diff/40001/status/elements.html
File status/elements.html (right):

https://codereview.chromium.org/1051173003/diff/40001/status/elements.html#ne...
status/elements.html:53: 
No blank line.

https://codereview.chromium.org/1051173003/diff/40001/status/res/imp/input-li...
File status/res/imp/input-list-sk.html (right):

https://codereview.chromium.org/1051173003/diff/40001/status/res/imp/input-li...
status/res/imp/input-list-sk.html:59: value: null,
Shouldn't this be "value: [],"

https://codereview.chromium.org/1051173003/diff/40001/status/res/imp/input-li...
status/res/imp/input-list-sk.html:66: this.value = [];
this.value isn't used anywhere, was it supposed to be values?

Setting here for values shouldn't be necessary if set in the publish section.

[borenet, 2015-04-02 14:57:21]

https://codereview.chromium.org/1051173003/diff/40001/status/elements.html
File status/elements.html (right):

https://codereview.chromium.org/1051173003/diff/40001/status/elements.html#ne...
status/elements.html:53: 
On 2015/04/02 14:43:14, jcgregorio wrote:
> No blank line.

Done.

https://codereview.chromium.org/1051173003/diff/40001/status/res/imp/input-li...
File status/res/imp/input-list-sk.html (right):

https://codereview.chromium.org/1051173003/diff/40001/status/res/imp/input-li...
status/res/imp/input-list-sk.html:59: value: null,
On 2015/04/02 14:43:14, jcgregorio wrote:
> Shouldn't this be "value: [],"

Done.

https://codereview.chromium.org/1051173003/diff/40001/status/res/imp/input-li...
status/res/imp/input-list-sk.html:66: this.value = [];
On 2015/04/02 14:43:14, jcgregorio wrote:
> this.value isn't used anywhere, was it supposed to be values?
> 
> Setting here for values shouldn't be necessary if set in the publish section.

Removed.

[jcgregorio, 2015-04-02 15:42:26]

https://codereview.chromium.org/1051173003/diff/60001/status/res/imp/bar-char...
File status/res/imp/bar-chart-sk.html (right):

https://codereview.chromium.org/1051173003/diff/60001/status/res/imp/bar-char...
status/res/imp/bar-chart-sk.html:64: var ChartsReady = new
Promise(function(resolve, reject) {
I think this can be simplified to:

var chartsReady = new Promise(function(resolve, reject) { 
    google.setOnLoadCallback(resolve);
});

[borenet, 2015-04-02 16:55:36]

https://codereview.chromium.org/1051173003/diff/60001/status/res/imp/bar-char...
File status/res/imp/bar-chart-sk.html (right):

https://codereview.chromium.org/1051173003/diff/60001/status/res/imp/bar-char...
status/res/imp/bar-chart-sk.html:64: var ChartsReady = new
Promise(function(resolve, reject) {
On 2015/04/02 15:42:26, jcgregorio wrote:
> I think this can be simplified to:
> 
> var chartsReady = new Promise(function(resolve, reject) { 
>     google.setOnLoadCallback(resolve);
> });

Done.

[jcgregorio, 2015-04-02 17:01:23]

lgtm

[borenet, 2015-04-02 17:18:10]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-04-02 17:18:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1051173003/80001

[commit-bot: I haz the power, 2015-04-02 17:19:50]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/buildbot/+/34567289359f9b62acbfd4cc4028ae82d304...