Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Issue 1051143004: Add debug logging to auth.py. (Closed)

Created:
5 years, 8 months ago by Vadim Sh.
Modified:
5 years, 8 months ago
Reviewers:
nodir, M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
tools
Visibility:
Public.

Description

Add debug logging to auth.py. There are some mysterious issues happening to some Windows users. Verbose log can be helpful. R=maruel@chromium.org BUG=356813 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294910

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M auth.py View 1 9 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Vadim Sh.
ptal
5 years, 8 months ago (2015-04-20 23:53:29 UTC) #1
nodir
https://codereview.chromium.org/1051143004/diff/1/auth.py File auth.py (right): https://codereview.chromium.org/1051143004/diff/1/auth.py#newcode537 auth.py:537: logging.debug('No %s', title) I think there is only one ...
5 years, 8 months ago (2015-04-21 00:01:12 UTC) #3
Vadim Sh.
https://codereview.chromium.org/1051143004/diff/1/auth.py File auth.py (right): https://codereview.chromium.org/1051143004/diff/1/auth.py#newcode537 auth.py:537: logging.debug('No %s', title) On 2015/04/21 00:01:11, nodir wrote: > ...
5 years, 8 months ago (2015-04-21 00:04:21 UTC) #4
nodir
I meant to assert credentials are not None, but this lgtm
5 years, 8 months ago (2015-04-21 00:07:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051143004/20001
5 years, 8 months ago (2015-04-21 00:08:57 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 00:12:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294910

Powered by Google App Engine
This is Rietveld 408576698