Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1051113005: Remove now-redundant SkPathOps enum. (Closed)

Created:
5 years, 8 months ago by Stephen Chennney
Modified:
5 years, 8 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove now-redundant SkPathOps enum. R=caryclark,reed BUG=473772 Committed: https://skia.googlesource.com/skia/+/143244e27d95255807d8fa505ce0affef96d1fc8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M include/pathops/SkPathOps.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Stephen Chennney
Depends on https://codereview.chromium.org/1057373002/ and https://codereview.chromium.org/1059833002/, so don't commit it yet.
5 years, 8 months ago (2015-04-03 20:04:26 UTC) #1
reed1
looks woot to me
5 years, 8 months ago (2015-04-03 20:06:39 UTC) #3
caryclark
lgtm
5 years, 8 months ago (2015-04-03 20:09:53 UTC) #4
reed1
lgtm
5 years, 8 months ago (2015-04-03 20:15:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051113005/1
5 years, 8 months ago (2015-04-06 16:30:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/143244e27d95255807d8fa505ce0affef96d1fc8
5 years, 8 months ago (2015-04-06 16:38:01 UTC) #8
scroggo
5 years, 8 months ago (2015-04-07 13:53:10 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1068873002/ by scroggo@google.com.

The reason for reverting is: Android is still using this. See
https://android-build.storage.googleapis.com/builds/git_master-skia-linux-raz....

Powered by Google App Engine
This is Rietveld 408576698