Issue 105103003: Move ui/base/ime/character_composer* to ui/base/ime/chromeos/

Issue 105103003: Move ui/base/ime/character_composer* to ui/base/ime/chromeos/ (Closed)

Created:
7 years ago by yoichio

Modified:
7 years ago

Reviewers:
Hiro Komatsu, Yuki

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move ui/base/ime/character_composer* to ui/base/ime/chromeos/ BUG=326778 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239439

Patch Set 1 #

Total comments: 3

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -1216 lines)			Patch
D	ui/base/ime/character_composer.h	View	1 chunk	+0 lines, -101 lines	0 comments	Download
D	ui/base/ime/character_composer.cc	View	1 chunk	+0 lines, -567 lines	0 comments	Download
D	ui/base/ime/character_composer_unittest.cc	View	1 chunk	+0 lines, -534 lines	0 comments	Download
A +	ui/base/ime/chromeos/character_composer.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/base/ime/chromeos/character_composer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	ui/base/ime/chromeos/character_composer_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/ime/ime.gypi	View	2 chunks	+6 lines, -6 lines	2 comments	Download
M	ui/base/ime/ime_unittests.gypi	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	ui/base/ime/input_method_ibus.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/105103003/1

7 years ago (2013-12-09 01:42:07 UTC) #3

Yuki

Just FYI. https://codereview.chromium.org/105103003/diff/1/ui/base/ime/ime.gypi File ui/base/ime/ime.gypi (right): https://codereview.chromium.org/105103003/diff/1/ui/base/ime/ime.gypi#newcode86 ui/base/ime/ime.gypi:86: 'chromeos/character_composer.h', 'chromeos' directory is automatically removed from ...

7 years ago (2013-12-09 02:25:00 UTC) #4

yoichio

https://codereview.chromium.org/105103003/diff/1/ui/base/ime/ime.gypi File ui/base/ime/ime.gypi (right): https://codereview.chromium.org/105103003/diff/1/ui/base/ime/ime.gypi#newcode86 ui/base/ime/ime.gypi:86: 'chromeos/character_composer.h', On 2013/12/09 02:25:00, Yuki wrote: > 'chromeos' directory ...

7 years ago (2013-12-09 04:08:34 UTC) #5

commit-bot: I haz the power

List of reviewers changed. yukishiino@chromium.org did a drive-by without LGTM'ing!

7 years ago (2013-12-09 06:23:19 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/105103003/1

7 years ago (2013-12-09 06:35:23 UTC) #8

Message was sent while issue was closed.

Change committed as 239439

Expand Messages | Collapse Messages