Source/core/svg/SVGViewSpec.h - Issue 1051023006: Fix SVG animations which check viewBox attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGViewSpec.h

Issue 1051023006: Fix SVG animations which check viewBox attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: LayoutTests/svg/animations/viewspec-animated-viewbox.html Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGViewSpec.h

diff --git a/Source/core/svg/SVGViewSpec.h b/Source/core/svg/SVGViewSpec.h

index c4a393eab97c355924da48e86a69952ce9fd0283..1d078452e18358db31fcfc8b7590433bc5978bbc 100644

--- a/Source/core/svg/SVGViewSpec.h

+++ b/Source/core/svg/SVGViewSpec.h

@@ -77,7 +77,7 @@ private:

template <typename T>

void SVGViewSpec::inheritViewAttributesFromElement(T* inheritFromElement)

{

- if (inheritFromElement->hasAttribute(SVGNames::viewBoxAttr))

+ if (!inheritFromElement->hasEmptyViewBox())

viewBox()->baseValue()->setValue(inheritFromElement->viewBox()->currentValue()->value());

if (inheritFromElement->hasAttribute(SVGNames::preserveAspectRatioAttr)) {

« no previous file with comments | « LayoutTests/svg/animations/viewspec-animated-viewbox-expected.html ('k') | no next file » | no next file with comments »