Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Unified Diff: Source/core/svg/SVGViewSpec.h

Issue 1051023006: Fix SVG animations which check viewBox attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix SVG animations which check viewBox attribute Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGViewSpec.h
diff --git a/Source/core/svg/SVGViewSpec.h b/Source/core/svg/SVGViewSpec.h
index c4a393eab97c355924da48e86a69952ce9fd0283..1d078452e18358db31fcfc8b7590433bc5978bbc 100644
--- a/Source/core/svg/SVGViewSpec.h
+++ b/Source/core/svg/SVGViewSpec.h
@@ -77,7 +77,7 @@ private:
template <typename T>
void SVGViewSpec::inheritViewAttributesFromElement(T* inheritFromElement)
{
- if (inheritFromElement->hasAttribute(SVGNames::viewBoxAttr))
+ if (!inheritFromElement->hasEmptyViewBox())
viewBox()->baseValue()->setValue(inheritFromElement->viewBox()->currentValue()->value());
fs 2015/04/22 10:56:51 This will just snapshot the value, which likely me
if (inheritFromElement->hasAttribute(SVGNames::preserveAspectRatioAttr)) {

Powered by Google App Engine
This is Rietveld 408576698