Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1051023002: Expose Cache Storage API in the global scope in stable (Closed)

Created:
5 years, 8 months ago by jsbell
Modified:
5 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose Cache Storage API in the global scope in stable Window/Worker global contexts will now have `caches` accessor for the origin's CacheStorage object. Remove the Service Worker-specific plumbing, now inherited from Worker. Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/M0x1Bcowjwc/grQBCJiXWsgJ Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache-objects BUG=439389 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193131

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 3 chunks +0 lines, -12 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jsbell
Will wait for https://codereview.chromium.org/1044203004/ to land first.
5 years, 8 months ago (2015-04-01 19:21:49 UTC) #1
pdr.
On 2015/04/01 at 19:21:49, jsbell wrote: > Will wait for https://codereview.chromium.org/1044203004/ to land first. LGTM
5 years, 8 months ago (2015-04-01 21:15:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051023002/1
5 years, 8 months ago (2015-04-03 16:28:45 UTC) #5
jsbell
On 2015/04/01 19:21:49, jsbell wrote: > Will wait for https://codereview.chromium.org/1044203004/ to land first. Per PM ...
5 years, 8 months ago (2015-04-03 16:29:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/50427)
5 years, 8 months ago (2015-04-03 16:32:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051023002/40001
5 years, 8 months ago (2015-04-03 16:39:10 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 18:00:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193131

Powered by Google App Engine
This is Rietveld 408576698