ui/ozone/platform/caca/caca_window_manager.cc - Issue 1050923003: zero-copy: Clarify to allocate/destroy GpuMemoryBuffer on any thread and use it on the main thread o

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/ozone/platform/caca/caca_window_manager.cc

Issue 1050923003: zero-copy: Clarify to allocate/destroy GpuMemoryBuffer on any thread and use it on the main thread o (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: just add thread check Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc ('K') | « ui/ozone/platform/caca/caca_window_manager.h ('k') | ui/ozone/platform/drm/drm_surface_factory.h » ('j') | ui/ozone/platform/drm/drm_surface_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/ozone/platform/caca/caca_window_manager.cc

diff --git a/ui/ozone/platform/caca/caca_window_manager.cc b/ui/ozone/platform/caca/caca_window_manager.cc

index 3e11ad29bed543d5f9ee12520bf303fbe137785f..2b5a5d224c56ce422031f8dc925f2f3ed4c68962 100644

--- a/ui/ozone/platform/caca/caca_window_manager.cc

+++ b/ui/ozone/platform/caca/caca_window_manager.cc

@@ -118,16 +118,19 @@ void CacaWindowManager::RemoveWindow(int window_id, CacaWindow* window) {

}

CacaWindowManager::~CacaWindowManager() {

+ DCHECK(thread_checker_.CalledOnValidThread());

reveman 2015/04/07 13:07:05 how are the DCHECKs in this file related to GpuMem

}

bool CacaWindowManager::LoadEGLGLES2Bindings(

AddGLLibraryCallback add_gl_library,

SetGLGetProcAddressProcCallback set_gl_get_proc_address) {

+ DCHECK(thread_checker_.CalledOnValidThread());

return false;

}

scoped_ptr<ui::SurfaceOzoneCanvas> CacaWindowManager::CreateCanvasForWidget(

gfx::AcceleratedWidget widget) {

+ DCHECK(thread_checker_.CalledOnValidThread());

CacaWindow* window = windows_.Lookup(widget);

DCHECK(window);