content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc - Issue 1050923003: zero-copy: Clarify to allocate/destroy GpuMemoryBuffer on any thread and use it on the main thread o

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc

Issue 1050923003: zero-copy: Clarify to allocate/destroy GpuMemoryBuffer on any thread and use it on the main thread o (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: just add thread check Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/gpu_memory_buffer_factory_io_surface.cc ('K') | « content/common/gpu/gpu_memory_buffer_factory_surface_texture.h ('k') | ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.h » ('j') | ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc

diff --git a/content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc b/content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc

index 1b2c881f6aeb2e5420e57cd9e5bf68eb4672e543..71fa0cdc86061b1ae86a00d82164f8c6ce96d663 100644

--- a/content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc

+++ b/content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc

@@ -105,7 +105,7 @@ GpuMemoryBufferFactorySurfaceTexture::CreateImageForGpuMemoryBuffer(

unsigned internalformat,

int client_id) {

base::AutoLock lock(surface_textures_lock_);

+ DCHECK(thread_checker_.CalledOnValidThread());

reveman 2015/04/07 13:07:05 ditto

dshwang 2015/04/07 14:04:26 ditto

DCHECK_EQ(handle.type, gfx::SURFACE_TEXTURE_BUFFER);

SurfaceTextureMapKey key(handle.id, client_id);