content/common/gpu/gpu_channel_manager.cc - Issue 1050923003: zero-copy: Clarify to allocate/destroy GpuMemoryBuffer on any thread and use it on the main thread o

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_channel_manager.cc

Issue 1050923003: zero-copy: Clarify to allocate/destroy GpuMemoryBuffer on any thread and use it on the main thread o (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: just add thread check Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/gpu_channel_manager.cc

diff --git a/content/common/gpu/gpu_channel_manager.cc b/content/common/gpu/gpu_channel_manager.cc

index 3d98e58e7292bc3f3cd18a0253dabe647897ca68..af999a892d0d9914f7d4c7caca7cf6851bd02b4e 100644

--- a/content/common/gpu/gpu_channel_manager.cc

+++ b/content/common/gpu/gpu_channel_manager.cc

@@ -59,6 +59,8 @@ class GpuChannelManagerMessageFilter : public IPC::MessageFilter {

protected:

~GpuChannelManagerMessageFilter() override {}

+ // The UI thread in the browser compositor must remain fast at all times.

+ // Bouncing off only GPU IO is the way to ensure that.

void OnCreateGpuMemoryBuffer(

const GpuMsg_CreateGpuMemoryBuffer_Params& params) {

TRACE_EVENT2("gpu",

« no previous file with comments | « no previous file | content/common/gpu/gpu_memory_buffer_factory.h » ('j') | content/common/gpu/gpu_memory_buffer_factory_io_surface.cc » ('J')