content/common/gpu/gpu_memory_buffer_factory_io_surface.h - Issue 1050923003: zero-copy: Clarify to allocate/destroy GpuMemoryBuffer on any thread and use it on the main thread o

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_memory_buffer_factory_io_surface.h

Issue 1050923003: zero-copy: Clarify to allocate/destroy GpuMemoryBuffer on any thread and use it on the main thread o (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/gpu_channel_manager.cc ('k') | content/common/gpu/gpu_memory_buffer_factory_io_surface.cc » ('j') | ui/ozone/public/surface_factory_ozone.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/gpu_memory_buffer_factory_io_surface.h

diff --git a/content/common/gpu/gpu_memory_buffer_factory_io_surface.h b/content/common/gpu/gpu_memory_buffer_factory_io_surface.h

index eac05adb58a37e96011373fa49563e5ec9dbe204..44f6da49892689a1d790be2b18f7ee8a62c22c60 100644

--- a/content/common/gpu/gpu_memory_buffer_factory_io_surface.h

+++ b/content/common/gpu/gpu_memory_buffer_factory_io_surface.h

@@ -10,7 +10,7 @@

#include "base/containers/hash_tables.h"

#include "base/mac/scoped_cftyperef.h"

#include "base/memory/ref_counted.h"

-#include "base/synchronization/lock.h"

+#include "base/threading/thread_checker.h"

#include "content/common/gpu/gpu_memory_buffer_factory.h"

#include "gpu/command_buffer/service/image_factory.h"

#include "ui/gfx/geometry/size.h"

@@ -59,7 +59,7 @@ class GpuMemoryBufferFactoryIOSurface : public GpuMemoryBufferFactory,

typedef base::hash_map<IOSurfaceMapKey, base::ScopedCFTypeRef<IOSurfaceRef>>

IOSurfaceMap;

IOSurfaceMap io_surfaces_;

- base::Lock io_surfaces_lock_;

+ base::ThreadChecker thread_checker_;

DISALLOW_COPY_AND_ASSIGN(GpuMemoryBufferFactoryIOSurface);

};