Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1050903002: Postpone check if password form is loaded from store (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index d7c49a89172d6b86dc685f2bb6fa095790407844..2da08e0e7004a1fbd0a7a6aa437a82bb6301cdb9 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -200,7 +200,6 @@ class PasswordFormManager : public PasswordStoreConsumer {
}
#endif
- protected:
const autofill::PasswordForm& observed_form() const { return observed_form_; }
private:
@@ -326,6 +325,10 @@ class PasswordFormManager : public PasswordStoreConsumer {
bool UploadPasswordForm(const autofill::FormData& form_data,
const autofill::ServerFieldType& password_type);
+ // Create pending credentials from provisionally saved form and forms received
+ // from password store.
+ void CreatePendingCredentials();
+
// Set of PasswordForms from the DB that best match the form
// being managed by this. Use a map instead of vector, because we most
// frequently require lookups by username value in IsNewLogin.
@@ -338,6 +341,12 @@ class PasswordFormManager : public PasswordStoreConsumer {
// The PasswordForm from the page or dialog managed by |this|.
const autofill::PasswordForm observed_form_;
+ // Stores provisionally saved form until |pending_credentials_| is created.
+ scoped_ptr<const autofill::PasswordForm> provisionally_saved_form_;
+ // Stores if for creating |pending_credentials_| other possible usernames
+ // option should apply.
+ OtherPossibleUsernamesAction other_possible_username_action_;
+
// The origin url path of observed_form_ tokenized, for convenience when
// scoring.
std::vector<std::string> form_path_tokens_;

Powered by Google App Engine
This is Rietveld 408576698