tools/ipc_fuzzer/message_lib/message_file_format.h - Issue 105083002: IPC fuzzer: create message_lib library.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/ipc_fuzzer/message_lib/message_file_format.h

Issue 105083002: IPC fuzzer: create message_lib library. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename map_ to mapped_file_. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tools/ipc_fuzzer/message_lib/message_file.h ('k') | tools/ipc_fuzzer/message_lib/message_file_reader.cc » ('j') | tools/ipc_fuzzer/message_lib/message_file_reader.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef TOOLS_IPC_FUZZER_MESSAGE_LIB_MESSAGE_FILE_FORMAT_H_

	6 #define TOOLS_IPC_FUZZER_MESSAGE_LIB_MESSAGE_FILE_FORMAT_H_

	7

	8 #include "base/basictypes.h"

	9
	Tom Sepez 2013/12/06 18:57:16 You'll want a comment here describing the format o You'll want a comment here describing the format of this file. ASCII art? aedla 2013/12/09 18:08:32 Done. Show quoted text On 2013/12/06 18:57:16, Tom Sepez wrote: > You'll want a comment here describing the format of this file. ASCII art? Done.
	10 namespace ipc_fuzzer {

	11

	12 struct FileHeader {

	13 uint32 message_count;
	Tom Sepez 2013/12/06 18:57:16 I'd suggests having a magic number here just to be I'd suggests having a magic number here just to be sure what you're opening is a message file. aedla 2013/12/09 18:08:32 Added magic and version. Show quoted text On 2013/12/06 18:57:16, Tom Sepez wrote: > I'd suggests having a magic number here just to be sure what you're opening is a > message file. Added magic and version.
	14 uint32 name_count;

	15 };
	Tom Sepez 2013/12/06 18:57:16 Hard to detect corruption if the counts are wrong Hard to detect corruption if the counts are wrong ... aedla 2013/12/09 18:08:32 I think it's unlikely that the magic is correct an Show quoted text On 2013/12/06 18:57:16, Tom Sepez wrote: > Hard to detect corruption if the counts are wrong ... I think it's unlikely that the magic is correct and counts are wrong. If it happens, I would think that further parsing will likely fail.
	16

	17 struct NameTableEntry {

	18 uint32 type;

	19 uint32 string_table_offset;

	20 };

	21

	22 } // namespace ipc_fuzzer

	23

	24 #endif // TOOLS_IPC_FUZZER_MESSAGE_LIB_MESSAGE_FILE_FORMAT_H_

OLD	NEW