Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

Issue 1050743003: replace request.node with request.target.containingNode in more situations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
index 8a910afede57c94d4461e280008fb639fe39f600..ac87e30dd1d1263d6c6de605aced7022f910eb37 100644
--- a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
+++ b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
@@ -377,7 +377,7 @@ class InterfaceTypeSuggestionBuilder {
*/
static void suggestionsFor(DartCompletionRequest request, DartType type) {
CompilationUnit compilationUnit =
- request.node.getAncestor((AstNode node) => node is CompilationUnit);
+ request.target.containingNode.getAncestor((n) => n is CompilationUnit);
LibraryElement library = compilationUnit.element.library;
if (type is DynamicTypeImpl) {
type = request.cache.objectClassElement.type;
@@ -442,7 +442,8 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
static void suggestionsFor(DartCompletionRequest request,
CompletionSuggestionKind kind, LibraryElement library, bool typesOnly) {
if (library != null) {
- library.visitChildren(new LibraryElementSuggestionBuilder(request, kind, typesOnly));
+ library.visitChildren(
+ new LibraryElementSuggestionBuilder(request, kind, typesOnly));
}
}
}

Powered by Google App Engine
This is Rietveld 408576698