Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1770)

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

Issue 1050743003: replace request.node with request.target.containingNode in more situations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/imported_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
index d4a91e7edd5cbe8fe24ada61aeb9f8ed26a8d352..ae924c054f6c731b0223ad11566f09ee6a7900e4 100644
--- a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
@@ -39,25 +39,24 @@ class ImportedComputer extends DartCompletionComputer {
shouldWaitForLowPrioritySuggestions;
// If target is an argument in an argument list
// then suggestions may need to be adjusted
- suggestionsComputed = builder.computeFast(request.node);
+ suggestionsComputed = builder.computeFast(request.target.containingNode);
return suggestionsComputed && request.target.argIndex == null;
}
return true;
}
@override
- Future<bool> computeFull(DartCompletionRequest request) {
+ Future<bool> computeFull(DartCompletionRequest request) async {
if (builder != null) {
if (!suggestionsComputed) {
- return builder.computeFull(request.node).then((bool result) {
- _updateSuggestions(request);
- return result;
- });
+ bool result = await builder.computeFull(request.target.containingNode);
+ _updateSuggestions(request);
+ return result;
}
_updateSuggestions(request);
- return new Future.value(true);
+ return true;
}
- return new Future.value(false);
+ return false;
}
/**
@@ -158,7 +157,8 @@ class _ImportedSuggestionBuilder extends ElementSuggestionBuilder
}
}
addSuggestion(elem, relevance: relevance);
- };
+ }
+ ;
}
/**

Powered by Google App Engine
This is Rietveld 408576698