Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: pkg/analysis_server/lib/src/services/completion/combinator_computer.dart

Issue 1050743003: replace request.node with request.target.containingNode in more situations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/combinator_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/combinator_computer.dart b/pkg/analysis_server/lib/src/services/completion/combinator_computer.dart
index 519383da390757978908cbf89e02340089330d71..6c296907d0ba1b28b9cb9764019b378ea28b85e8 100644
--- a/pkg/analysis_server/lib/src/services/completion/combinator_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/combinator_computer.dart
@@ -22,14 +22,15 @@ class CombinatorComputer extends DartCompletionComputer {
@override
bool computeFast(DartCompletionRequest request) {
- builder = request.node.accept(new _CombinatorAstVisitor(request));
+ builder = request.target.containingNode
+ .accept(new _CombinatorAstVisitor(request));
return builder == null;
}
@override
Future<bool> computeFull(DartCompletionRequest request) {
if (builder != null) {
- return builder.execute(request.node);
+ return builder.execute(request.target.containingNode);
}
return new Future.value(false);
}
@@ -55,11 +56,6 @@ class _CombinatorAstVisitor
_CombinatorSuggestionBuilder visitNode(AstNode node) {
return null;
}
-
- @override
- _CombinatorSuggestionBuilder visitSimpleIdentifier(SimpleIdentifier node) {
- return node.parent.accept(this);
- }
}
/**

Powered by Google App Engine
This is Rietveld 408576698