ServiceWorker: Clean up ServiceWorkerVersion::OnGetClients

ServiceWorker: Clean up ServiceWorkerVersion::OnGetClients

This is a follow-up CL for https://codereview.chromium.org/1042933002/

BUG=460415
TEST=n/a

Committed: https://crrev.com/0478c6bd92b19e67bbd380df08bb14455cebb3e4
Cr-Commit-Position: refs/heads/master@{#323183}

[nhiroki, 2015-04-01 00:46:21]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2015-04-01 00:52:44]

PTAL, thanks!

[falken, 2015-04-01 01:39:22]

lgtm

https://codereview.chromium.org/1050733002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/1050733002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_version.cc:1546: //
matchAll(options)
This looks like commented out code rather than a reference to the spec. I guess
we have to say something like "This implements the spec's matchAll(options)
steps."

[nhiroki, 2015-04-01 03:28:56]

https://codereview.chromium.org/1050733002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/1050733002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_version.cc:1546: //
matchAll(options)
On 2015/04/01 01:39:21, falken wrote:
> This looks like commented out code rather than a reference to the spec. I
guess
> we have to say something like "This implements the spec's matchAll(options)
> steps."

Hmm... I found this method doesn't completely correspond to the
matchAll(options) because this doesn't take care of "client_type == TypeWorker"
etc. OnGetClients() would be more suitable place for the comment.

[nhiroki, 2015-04-01 03:34:04]

Patchset #3 (id:40001) has been deleted

[nhiroki, 2015-04-01 03:36:47]

Patchset #3 (id:60001) has been deleted

[nhiroki, 2015-04-01 03:39:56]

https://codereview.chromium.org/1050733002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/1050733002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_version.cc:1546: //
matchAll(options)
On 2015/04/01 03:28:56, nhiroki wrote:
> On 2015/04/01 01:39:21, falken wrote:
> > This looks like commented out code rather than a reference to the spec. I
> guess
> > we have to say something like "This implements the spec's matchAll(options)
> > steps."
> 
> Hmm... I found this method doesn't completely correspond to the
> matchAll(options) because this doesn't take care of "client_type ==
TypeWorker"
> etc. OnGetClients() would be more suitable place for the comment.

Moved.

[nhiroki, 2015-04-01 03:40:00]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2015-04-01 03:40:00]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1050733002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-04-01 03:40:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1050733002/80001

[commit-bot: I haz the power, 2015-04-01 04:28:14]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-04-01 04:29:12]

Patchset 3 (id:??) landed as
https://crrev.com/0478c6bd92b19e67bbd380df08bb14455cebb3e4
Cr-Commit-Position: refs/heads/master@{#323183}