Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 105073003: Adds a sample for polymer internationalization/localization (Closed)

Created:
7 years ago by Alan Knight
Modified:
7 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adds a sample for polymer internationalization/localization BUG= R=jmesserly@google.com, shailentuli@google.com Committed: https://code.google.com/p/dart/source/detail?r=30998

Patch Set 1 #

Patch Set 2 : Made a line fit in the prescribed length #

Total comments: 15

Patch Set 3 : Changes from review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -47 lines) Patch
A samples/polymer_intl/README.md View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A + samples/polymer_intl/build.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
A samples/polymer_intl/pubspec.yaml View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A + samples/polymer_intl/test/polymer_intl_test.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + samples/polymer_intl/test/polymer_intl_test.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A samples/polymer_intl/web/intl_messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A samples/polymer_intl/web/localized.dart View 1 chunk +77 lines, -0 lines 0 comments Download
A samples/polymer_intl/web/localized.html View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A + samples/polymer_intl/web/messages_all.dart View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
A + samples/polymer_intl/web/messages_fr.dart View 1 2 1 chunk +10 lines, -9 lines 0 comments Download
A + samples/polymer_intl/web/messages_pt.dart View 1 2 1 chunk +10 lines, -9 lines 0 comments Download
A + samples/polymer_intl/web/polymer_intl.css View 1 2 2 chunks +4 lines, -17 lines 0 comments Download
A samples/polymer_intl/web/polymer_intl.html View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A samples/polymer_intl/web/translation_fr.json View 1 chunk +2 lines, -0 lines 0 comments Download
A samples/polymer_intl/web/translation_pt.json View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Alan Knight
7 years ago (2013-12-04 19:08:03 UTC) #1
Alan Knight
I note there's one glitch in this which is that the select doesn't show up ...
7 years ago (2013-12-04 19:14:35 UTC) #2
sethladd
Related to https://code.google.com/p/dart/issues/detail?id=13922 ?
7 years ago (2013-12-04 19:43:33 UTC) #3
Alan Knight
Ping
7 years ago (2013-12-06 21:50:35 UTC) #4
Jennifer Messerly
https://chromiumcodereview.appspot.com/105073003/diff/20001/samples/polymer_intl/build.dart File samples/polymer_intl/build.dart (right): https://chromiumcodereview.appspot.com/105073003/diff/20001/samples/polymer_intl/build.dart#newcode4 samples/polymer_intl/build.dart:4: build(entryPoints: ['web/polymerinternationalizedmessagesexample.html'], this could really use a shorter name ...
7 years ago (2013-12-06 22:19:44 UTC) #5
Jennifer Messerly
On 2013/12/06 22:19:44, John Messerly wrote: > https://chromiumcodereview.appspot.com/105073003/diff/20001/samples/polymer_intl/build.dart > File samples/polymer_intl/build.dart (right): > > https://chromiumcodereview.appspot.com/105073003/diff/20001/samples/polymer_intl/build.dart#newcode4 ...
7 years ago (2013-12-06 22:20:00 UTC) #6
shailentuli
Alan, thanks for putting together the sample. I'm giving it a quick first look. Sorry, ...
7 years ago (2013-12-06 22:33:38 UTC) #7
Jennifer Messerly
On 2013/12/06 22:33:38, shailentuli wrote: > Alan, thanks for putting together the sample. I'm giving ...
7 years ago (2013-12-06 23:09:26 UTC) #8
Alan Knight
OK, added copyright notices (Dan had told me we didn't need them in HTML files, ...
7 years ago (2013-12-06 23:52:31 UTC) #9
Jennifer Messerly
> Dan had told me we didn't need them in HTML files, and they seem ...
7 years ago (2013-12-07 01:43:01 UTC) #10
Jennifer Messerly
lgtm
7 years ago (2013-12-07 01:43:56 UTC) #11
shailentuli
lgtm
7 years ago (2013-12-07 04:48:15 UTC) #12
Alan Knight
7 years ago (2013-12-09 20:58:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 manually as r30998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698